From patchwork Sun May 17 09:02:46 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uri Shkolnik X-Patchwork-Id: 24294 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4H92nnO014067 for ; Sun, 17 May 2009 09:02:49 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754378AbZEQJCq (ORCPT ); Sun, 17 May 2009 05:02:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754358AbZEQJCq (ORCPT ); Sun, 17 May 2009 05:02:46 -0400 Received: from web110815.mail.gq1.yahoo.com ([67.195.13.238]:46583 "HELO web110815.mail.gq1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752641AbZEQJCq (ORCPT ); Sun, 17 May 2009 05:02:46 -0400 Received: (qmail 19095 invoked by uid 60001); 17 May 2009 09:02:47 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1242550967; bh=K1YNxSK8QljhHP+19CUocVkGcGR4Io5pdFEL+floFpM=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:MIME-Version:Content-Type; b=qNNBFpIU8360un0Y/Z38nnAHt0cbqWt83iKf1jdythvatHbjrdkuaTRCXJwZUIL9tQA3gFjvybi11JmE1325USF9Gk+kZ5H09DVyPvdEs5xkQ7LUltI4zb/nWzlIJWlpcQ7W36fV4RI4zCKBItdZHgSyv+VO5fTubzptxPFTf2I= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:MIME-Version:Content-Type; b=gS0hb+G5KDSmVJxY8lA43sDGoBwdHQ1jH06+d6qpR7gi2T2XBeWQDbNA70r8/AQqlDpKl+dMUKtlzLKAUpWSkVVMVyJjkcbPEVsUFtw6/6EELMg62ILiDhYuxOt2a5w/RXOE+/T/XHTLQnxR0P0o15oVv+2KVoh4k2bEzd/9oaM=; Message-ID: <16292.18803.qm@web110815.mail.gq1.yahoo.com> X-YMail-OSG: 6YdgH7AVM1kE3q7LTrk3BSOucMbKOixOv.fgoK2r70_3ft0HYcTJuKC9URKCtsgf1oghSuCdHGoHftKB7SU2.TxMr6Je2T5wOQIhu3.2oeHAzyMR5B.lhmq3UsKEKKm1DT9SiDRIVr8WguFrFMvqOGCRB7pd2jpjEmOaZ8QTJ35zhq_CFbyE6uE55TORmXxC2MeaQCcsiKhWgfZWflgzMeyut88I0lBCeF7tClYhZ81kg2V1VSZPrB7lJPCgTNHUvscmP_XCspYotQpf.kcKdlE.XgiXjiy7DSisn.l0SsyH1wt4gtGqP34OZ7_gBnsLf8JuOmcJQ8W3QGgxcFl1QguSjDJcpSozAC9ZHGRU9ezcANA7jPnHkUmUXg-- Received: from [199.203.99.233] by web110815.mail.gq1.yahoo.com via HTTP; Sun, 17 May 2009 02:02:46 PDT X-Mailer: YahooMailClassic/5.3.9 YahooMailWebService/0.7.289.10 Date: Sun, 17 May 2009 02:02:46 -0700 (PDT) From: Uri Shkolnik Subject: [PATCH] [0905_29] Siano: smscore - bug fix at get_device_mode To: LinuxML MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org # HG changeset patch # User Uri Shkolnik # Date 1242332841 -10800 # Node ID 211989f20f803bc5a719c6fda4640888e379d6fc # Parent 7e56c108996ef016c4b2117090e2577aea9ed56c [0905_29] Siano: smscore - bug fix at get_device_mode From: Uri Shkolnik Fix bug that cause error log to echo also if success Priority: normal Signed-off-by: Uri Shkolnik --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -r 7e56c108996e -r 211989f20f80 linux/drivers/media/dvb/siano/smscoreapi.c --- a/linux/drivers/media/dvb/siano/smscoreapi.c Thu May 14 23:24:44 2009 +0300 +++ b/linux/drivers/media/dvb/siano/smscoreapi.c Thu May 14 23:27:21 2009 +0300 @@ -938,7 +938,7 @@ int smscore_set_device_mode(struct smsco coredev->device_flags &= ~SMS_DEVICE_NOT_READY; } - if (rc != 0) + if (rc < 0) sms_err("return error code %d.", rc); return rc; }