From patchwork Mon Apr 16 16:37:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10343463 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D5E20601D7 for ; Mon, 16 Apr 2018 16:37:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C7D8E28815 for ; Mon, 16 Apr 2018 16:37:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BCB402881C; Mon, 16 Apr 2018 16:37:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28E7F28815 for ; Mon, 16 Apr 2018 16:37:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752204AbeDPQhV (ORCPT ); Mon, 16 Apr 2018 12:37:21 -0400 Received: from osg.samsung.com ([64.30.133.232]:33319 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbeDPQhU (ORCPT ); Mon, 16 Apr 2018 12:37:20 -0400 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id F249626EA1; Mon, 16 Apr 2018 09:37:19 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VqvBd2KBZESO; Mon, 16 Apr 2018 09:37:18 -0700 (PDT) Received: from smtp.s-opensource.com (unknown [201.86.164.1]) by osg.samsung.com (Postfix) with ESMTPSA id 3E14026E5C; Mon, 16 Apr 2018 09:37:16 -0700 (PDT) Received: from mchehab by smtp.s-opensource.com with local (Exim 4.90_1) (envelope-from ) id 1f877x-0004Ay-GA; Mon, 16 Apr 2018 12:37:13 -0400 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Mauro Carvalho Chehab , Alan Cox , Sakari Ailus , Greg Kroah-Hartman , Andy Shevchenko , Hans Verkuil , Julia Lawall , Arvind Yadav , devel@driverdev.osuosl.org Subject: [PATCH 9/9] media: atomisp-mt9m114: comment out unused stuff Date: Mon, 16 Apr 2018 12:37:12 -0400 Message-Id: <19ed5c24c1efe1dfb3867a9ed91f02b27c97317f.1523896259.git.mchehab@s-opensource.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: References: In-Reply-To: References: To: unlisted-recipients:; (no To-header on input) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There are lots of data structs defined there but aren't used anywhere. Comment them out. Gets rid of those warnings: drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c:1808:45: warning: 'mt9m114_entity_ops' defined but not used [-Wunused-const-variable=] static const struct media_entity_operations mt9m114_entity_ops = { ^~~~~~~~~~~~~~~~~~ In file included from drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c:35:0: drivers/staging/media/atomisp/i2c/mt9m114.h:805:34: warning: 'mt9m114_iq' defined but not used [-Wunused-const-variable=] static struct misensor_reg const mt9m114_iq[] = { ^~~~~~~~~~ drivers/staging/media/atomisp/i2c/mt9m114.h:797:34: warning: 'mt9m114_antiflicker_60hz' defined but not used [-Wunused-const-variable=] static struct misensor_reg const mt9m114_antiflicker_60hz[] = { ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp/i2c/mt9m114.h:789:34: warning: 'mt9m114_antiflicker_50hz' defined but not used [-Wunused-const-variable=] static struct misensor_reg const mt9m114_antiflicker_50hz[] = { ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp/i2c/mt9m114.h:682:34: warning: 'mt9m114_720_480P_init' defined but not used [-Wunused-const-variable=] static struct misensor_reg const mt9m114_720_480P_init[] = { ^~~~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp/i2c/mt9m114.h:533:34: warning: 'mt9m114_960P_init' defined but not used [-Wunused-const-variable=] static struct misensor_reg const mt9m114_960P_init[] = { ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp/i2c/mt9m114.h:518:34: warning: 'mt9m114_wakeup_reg' defined but not used [-Wunused-const-variable=] static struct misensor_reg const mt9m114_wakeup_reg[] = { ^~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp/i2c/mt9m114.h:504:34: warning: 'mt9m114_streaming' defined but not used [-Wunused-const-variable=] static struct misensor_reg const mt9m114_streaming[] = { ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp/i2c/mt9m114.h:497:34: warning: 'mt9m114_suspend' defined but not used [-Wunused-const-variable=] static struct misensor_reg const mt9m114_suspend[] = { ^~~~~~~~~~~~~~~ drivers/staging/media/atomisp/i2c/mt9m114.h:393:34: warning: 'mt9m114_exitstandby' defined but not used [-Wunused-const-variable=] static struct misensor_reg const mt9m114_exitstandby[] = { ^~~~~~~~~~~~~~~~~~~ Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 4 ---- drivers/staging/media/atomisp/i2c/mt9m114.h | 13 ++++++++++++- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c index 454a5c31a206..8e180f903335 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c @@ -1805,10 +1805,6 @@ static const struct v4l2_subdev_ops mt9m114_ops = { .sensor = &mt9m114_sensor_ops, }; -static const struct media_entity_operations mt9m114_entity_ops = { - .link_setup = NULL, -}; - static int mt9m114_remove(struct i2c_client *client) { struct mt9m114_device *dev; diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.h b/drivers/staging/media/atomisp/i2c/mt9m114.h index 0af79d77a404..de39cc141308 100644 --- a/drivers/staging/media/atomisp/i2c/mt9m114.h +++ b/drivers/staging/media/atomisp/i2c/mt9m114.h @@ -390,6 +390,7 @@ static struct mt9m114_res_struct mt9m114_res[] = { }; #define N_RES (ARRAY_SIZE(mt9m114_res)) +#if 0 /* Currently unused */ static struct misensor_reg const mt9m114_exitstandby[] = { {MISENSOR_16BIT, 0x098E, 0xDC00}, /* exit-standby */ @@ -397,6 +398,7 @@ static struct misensor_reg const mt9m114_exitstandby[] = { {MISENSOR_16BIT, 0x0080, 0x8002}, {MISENSOR_TOK_TERM, 0, 0} }; +#endif static struct misensor_reg const mt9m114_exp_win[5][5] = { { @@ -494,6 +496,7 @@ static struct misensor_reg const mt9m114_exp_center[] = { {MISENSOR_TOK_TERM, 0, 0} }; +#if 0 /* Currently unused */ static struct misensor_reg const mt9m114_suspend[] = { {MISENSOR_16BIT, 0x098E, 0xDC00}, {MISENSOR_8BIT, 0xDC00, 0x40}, @@ -507,6 +510,7 @@ static struct misensor_reg const mt9m114_streaming[] = { {MISENSOR_16BIT, 0x0080, 0x8002}, {MISENSOR_TOK_TERM, 0, 0} }; +#endif static struct misensor_reg const mt9m114_standby_reg[] = { {MISENSOR_16BIT, 0x098E, 0xDC00}, @@ -515,12 +519,14 @@ static struct misensor_reg const mt9m114_standby_reg[] = { {MISENSOR_TOK_TERM, 0, 0} }; +#if 0 /* Currently unused */ static struct misensor_reg const mt9m114_wakeup_reg[] = { {MISENSOR_16BIT, 0x098E, 0xDC00}, {MISENSOR_8BIT, 0xDC00, 0x54}, {MISENSOR_16BIT, 0x0080, 0x8002}, {MISENSOR_TOK_TERM, 0, 0} }; +#endif static struct misensor_reg const mt9m114_chgstat_reg[] = { {MISENSOR_16BIT, 0x098E, 0xDC00}, @@ -530,6 +536,7 @@ static struct misensor_reg const mt9m114_chgstat_reg[] = { }; /* [1296x976_30fps] - Intel */ +#if 0 static struct misensor_reg const mt9m114_960P_init[] = { {MISENSOR_16BIT, 0x098E, 0x1000}, {MISENSOR_8BIT, 0xC97E, 0x01}, /* cam_sysctl_pll_enable = 1 */ @@ -565,6 +572,7 @@ static struct misensor_reg const mt9m114_960P_init[] = { {MISENSOR_16BIT, 0xC86A, 0x03C8}, /* cam_output_height = 960 */ {MISENSOR_TOK_TERM, 0, 0}, }; +#endif /* [1296x976_30fps_768Mbps] */ static struct misensor_reg const mt9m114_976P_init[] = { @@ -679,6 +687,7 @@ static struct misensor_reg const mt9m114_736P_init[] = { }; /* [736x496_30fps_768Mbps] */ +#if 0 /* Currently unused */ static struct misensor_reg const mt9m114_720_480P_init[] = { {MISENSOR_16BIT, 0x98E, 0x1000}, {MISENSOR_8BIT, 0xC97E, 0x01}, /* cam_sysctl_pll_enable = 1 */ @@ -714,6 +723,7 @@ static struct misensor_reg const mt9m114_720_480P_init[] = { {MISENSOR_8BIT, 0xC878, 0x00}, /* 0x0E //cam_aet_aemode = 0 */ {MISENSOR_TOK_TERM, 0, 0} }; +#endif static struct misensor_reg const mt9m114_common[] = { /* reset */ @@ -785,7 +795,7 @@ static struct misensor_reg const mt9m114_common[] = { {MISENSOR_TOK_TERM, 0, 0}, }; - +#if 0 /* Currently unused */ static struct misensor_reg const mt9m114_antiflicker_50hz[] = { {MISENSOR_16BIT, 0x098E, 0xC88B}, {MISENSOR_8BIT, 0xC88B, 0x32}, @@ -1775,3 +1785,4 @@ static struct misensor_reg const mt9m114_iq[] = { }; #endif +#endif