diff mbox

[2/2,media] media.h: get rid of MEDIA_ENT_F_CONN_TEST

Message ID 1ae039a008139caa409c4e20b57d2404be282f5f.1455311900.git.mchehab@osg.samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab Feb. 12, 2016, 9:18 p.m. UTC 
Defining it as a connector was a bad idea. Remove it while it is
not too late.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
---
 Documentation/DocBook/media/v4l/media-types.xml | 4 ----
 drivers/media/v4l2-core/v4l2-mc.c               | 1 -
 include/uapi/linux/media.h                      | 2 --
 3 files changed, 7 deletions(-)

Comments

kernel test robot Feb. 12, 2016, 10:03 p.m. UTC | #1 
Hi Mauro,

[auto build test ERROR on linuxtv-media/master]
[cannot apply to v4.5-rc3 next-20160212]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/tvp5150-replace-MEDIA_ENT_F_CONN_TEST-by-a-control/20160213-052526
base:   git://linuxtv.org/media_tree.git master
config: x86_64-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Mauro-Carvalho-Chehab/tvp5150-replace-MEDIA_ENT_F_CONN_TEST-by-a-control/20160213-052526 HEAD 63e43d46d30abbc15209674bb807449b329ce04b builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/media/usb/au0828/au0828-video.c: In function 'au0828_analog_create_entities':
>> drivers/media/usb/au0828/au0828-video.c:1994:20: error: 'MEDIA_ENT_F_CONN_TEST' undeclared (first use in this function)
       ent->function = MEDIA_ENT_F_CONN_TEST;
                       ^
   drivers/media/usb/au0828/au0828-video.c:1994:20: note: each undeclared identifier is reported only once for each function it appears in

vim +/MEDIA_ENT_F_CONN_TEST +1994 drivers/media/usb/au0828/au0828-video.c

d1f33737 Mauro Carvalho Chehab 2015-08-31  1988  		case AU0828_VMUX_CABLE:
d1f33737 Mauro Carvalho Chehab 2015-08-31  1989  		case AU0828_VMUX_TELEVISION:
d1f33737 Mauro Carvalho Chehab 2015-08-31  1990  		case AU0828_VMUX_DVB:
4ca72efa Mauro Carvalho Chehab 2015-12-10  1991  			ent->function = MEDIA_ENT_F_CONN_RF;
d1f33737 Mauro Carvalho Chehab 2015-08-31  1992  			break;
d1f33737 Mauro Carvalho Chehab 2015-08-31  1993  		default: /* AU0828_VMUX_DEBUG */
4ca72efa Mauro Carvalho Chehab 2015-12-10 @1994  			ent->function = MEDIA_ENT_F_CONN_TEST;
d1f33737 Mauro Carvalho Chehab 2015-08-31  1995  			break;
d1f33737 Mauro Carvalho Chehab 2015-08-31  1996  		}
d1f33737 Mauro Carvalho Chehab 2015-08-31  1997  

:::::: The code at line 1994 was first introduced by commit
:::::: 4ca72efaeffd0d244c44307abc9d4cb11f8ad475 [media] uapi/media.h: Rename entities types to functions

:::::: TO: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/Documentation/DocBook/media/v4l/media-types.xml b/Documentation/DocBook/media/v4l/media-types.xml
index 751c3d027103..8b4fa39cf611 100644
--- a/Documentation/DocBook/media/v4l/media-types.xml
+++ b/Documentation/DocBook/media/v4l/media-types.xml
@@ -57,10 +57,6 @@ 
 	    <entry>Connector for a RGB composite signal.</entry>
 	  </row>
 	  <row>
-	    <entry><constant>MEDIA_ENT_F_CONN_TEST</constant></entry>
-	    <entry>Connector for a test generator.</entry>
-	  </row>
-	  <row>
 	    <entry><constant>MEDIA_ENT_F_CAM_SENSOR</constant></entry>
 	    <entry>Camera video sensor entity.</entry>
 	  </row>
diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c
index b61f8d969958..cdf87615dc78 100644
--- a/drivers/media/v4l2-core/v4l2-mc.c
+++ b/drivers/media/v4l2-core/v4l2-mc.c
@@ -241,7 +241,6 @@  int v4l2_mc_create_media_graph(struct media_device *mdev)
 			break;
 		case MEDIA_ENT_F_CONN_SVIDEO:
 		case MEDIA_ENT_F_CONN_COMPOSITE:
-		case MEDIA_ENT_F_CONN_TEST:
 			ret = media_create_pad_link(entity, 0, decoder,
 						    DEMOD_PAD_IF_INPUT,
 						    flags);
diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
index c9eb42a6c021..7113b1a8cb4e 100644
--- a/include/uapi/linux/media.h
+++ b/include/uapi/linux/media.h
@@ -78,8 +78,6 @@  struct media_device_info {
 #define MEDIA_ENT_F_CONN_RF		(MEDIA_ENT_F_BASE + 21)
 #define MEDIA_ENT_F_CONN_SVIDEO		(MEDIA_ENT_F_BASE + 22)
 #define MEDIA_ENT_F_CONN_COMPOSITE	(MEDIA_ENT_F_BASE + 23)
-/* For internal test signal generators and other debug connectors */
-#define MEDIA_ENT_F_CONN_TEST		(MEDIA_ENT_F_BASE + 24)
 
 /*
  * I/O entities