| Message ID | 1e4da85e-b975-4638-bd14-09ba0675d9d6@stanley.mountain (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] media: i2c: imx214: Fix uninitialized variable in imx214_set_ctrl() | expand |
Am Dienstag, dem 18.02.2025 um 16:05 +0300 schrieb Dan Carpenter: > You can't pass uninitialized "ret" variables to cci_write(). It has > to start as zero. > > Fixes: 4f0aeba4f155 ("media: i2c: imx214: Convert to CCI register > access helpers") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/media/i2c/imx214.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c > index 6c3f6f3c8b1f..68775ee8256e 100644 > --- a/drivers/media/i2c/imx214.c > +++ b/drivers/media/i2c/imx214.c > @@ -795,7 +795,7 @@ static int imx214_set_ctrl(struct v4l2_ctrl > *ctrl) > struct imx214, ctrls); > const struct v4l2_mbus_framefmt *format = NULL; > struct v4l2_subdev_state *state; > - int ret; > + int ret = 0; > > if (ctrl->id == V4L2_CID_VBLANK) { > int exposure_max, exposure_def; Thanks. Reviewed-by: André Apitzsch <git@apitzsch.eu>
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 6c3f6f3c8b1f..68775ee8256e 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -795,7 +795,7 @@ static int imx214_set_ctrl(struct v4l2_ctrl *ctrl) struct imx214, ctrls); const struct v4l2_mbus_framefmt *format = NULL; struct v4l2_subdev_state *state; - int ret; + int ret = 0; if (ctrl->id == V4L2_CID_VBLANK) { int exposure_max, exposure_def;
You can't pass uninitialized "ret" variables to cci_write(). It has to start as zero. Fixes: 4f0aeba4f155 ("media: i2c: imx214: Convert to CCI register access helpers") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/media/i2c/imx214.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)