From patchwork Thu Jan 8 17:44:11 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Werner X-Patchwork-Id: 1393 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n08HeZJG015294 for ; Thu, 8 Jan 2009 09:40:36 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756404AbZAHRoP (ORCPT ); Thu, 8 Jan 2009 12:44:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756176AbZAHRoO (ORCPT ); Thu, 8 Jan 2009 12:44:14 -0500 Received: from mail.gmx.net ([213.165.64.20]:39808 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755506AbZAHRoN (ORCPT ); Thu, 8 Jan 2009 12:44:13 -0500 Received: (qmail 27283 invoked by uid 0); 8 Jan 2009 17:44:11 -0000 Received: from 88.96.7.158 by www050.gmx.net with HTTP; Thu, 08 Jan 2009 18:44:11 +0100 (CET) Date: Thu, 08 Jan 2009 18:44:11 +0100 From: "Hans Werner" In-Reply-To: <20090108100149.2c6df55e@pedra.chehab.org> Message-ID: <20090108174411.293680@gmx.net> MIME-Version: 1.0 References: <20090105152029.293080@gmx.net> <20090108100149.2c6df55e@pedra.chehab.org> Subject: [PATCH] [RESEND] stb6100: stb6100_init fix To: linux-media@vger.kernel.org X-Authenticated: #21834385 X-Flags: 0001 X-Mailer: WWW-Mail 6100 (Global Message Exchange) X-Priority: 3 X-Provags-ID: V01U2FsdGVkX18t+0hmhr4tI8Z7qsnxNNxZQdCsCqdGGNtdhVnvL6 2krAb9cfMcXkeFtqyK4SMMSM3jemPfjGMMvA== X-GMX-UID: XwlUeolFPTR+dqYZfDMw2Ho5c2tpZIsR X-FuHaFi: 0.52 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org > > Hi Mauro, > > please look at the patch below. > > > > Signed-off-by: Hans Werner > > > > Thanks, > > Hans > > > > -------- Original-Nachricht -------- > > Datum: Mon, 05 Jan 2009 16:10:50 +0100 > > Von: "Hans Werner" > > An: linux-dvb@linuxtv.org > > Betreff: [linux-dvb] [PATCH] stb6100: stb6100_init fix > > > > Two issues in stb6100_init : the call to stb6100_set_bandwidth needs an > argument in Hz > > not kHz, and a comment incorrectly says MHz instead of Hz. I don't know > if this caused > > real problems anywhere. > > > > This patch is for v4l-dvb, but it is also needs to be fixed in > s2-liplianin. > > > > ... > > ... > > Considering that the ioctl use "state" instead of "status", your patch > looks > sane: > > case DVBFE_TUNER_BANDWIDTH: > stb6100_set_bandwidth(fe, state->bandwidth); > > Could you please re-send this patch to me, mentioning the above, > explicitly C/C > Manu, linux-media and linux-dvb ML's? Please, mark the patch as a resend. > > Cheers, > Mauro Resending the following patch as requested by Mauro. Signed-off-by: Hans Werner diff -r b7e7abe3e3aa linux/drivers/media/dvb/frontends/stb6100.c --- a/linux/drivers/media/dvb/frontends/stb6100.c +++ b/linux/drivers/media/dvb/frontends/stb6100.c @@ -434,11 +434,11 @@ static int stb6100_init(struct dvb_front status->refclock = 27000000; /* Hz */ status->iqsense = 1; status->bandwidth = 36000; /* kHz */ - state->bandwidth = status->bandwidth * 1000; /* MHz */ + state->bandwidth = status->bandwidth * 1000; /* Hz */ state->reference = status->refclock / 1000; /* kHz */ /* Set default bandwidth. */ - return stb6100_set_bandwidth(fe, status->bandwidth); + return stb6100_set_bandwidth(fe, state->bandwidth); } static int stb6100_get_state(struct dvb_frontend *fe,