From patchwork Sun Jan 18 18:21:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Tettamanti X-Patchwork-Id: 3044 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n0IIEOhQ022786 for ; Sun, 18 Jan 2009 10:16:49 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752464AbZARSVN (ORCPT ); Sun, 18 Jan 2009 13:21:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752654AbZARSVN (ORCPT ); Sun, 18 Jan 2009 13:21:13 -0500 Received: from mail-bw0-f21.google.com ([209.85.218.21]:59942 "EHLO mail-bw0-f21.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752464AbZARSVM (ORCPT ); Sun, 18 Jan 2009 13:21:12 -0500 Received: by bwz14 with SMTP id 14so7255590bwz.13 for ; Sun, 18 Jan 2009 10:21:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:cc :subject:message-id:mime-version:content-type:content-disposition :user-agent; bh=+bAHwvW4cIDO6CwzHLUA7x0L+gowCO7ns6oVbVduTEM=; b=FLBcGciDUkGTWLvRYSI+bzdqA4AP9R1+GJ8gBoGGvGgwQlm9WJZwNFjJzJzRyrXzlN hvkClZ0vycu9eh9ByVsgqzlliihvmwgd+f+TNsgc91PNiskfz0hV23M5bm+Qs5I0K/Js rhOfJHlQlZ9A2kS3t+wLIxKJcSowLcIzYysvw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=c/Qc/zRD4oZ0R14hVsT39P2qxXk3biV65aWGt4+kVlqNsb672ukJQ3bmQQAMotPD3M zoWUKQdzvdIgi/oehXa/+NzoOaNLex6yqnJkbQEFDoItpxkaL2hyHBfAShXpvH5KpZn+ ex99qdn+MqE11FSshADu3cbaalzr3BET4/xYg= Received: by 10.103.24.11 with SMTP id b11mr2164953muj.76.1232302870522; Sun, 18 Jan 2009 10:21:10 -0800 (PST) Received: from dreamland.darkstar.lan ([78.14.224.126]) by mx.google.com with ESMTPS id e9sm5720728muf.51.2009.01.18.10.21.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 18 Jan 2009 10:21:09 -0800 (PST) Received: by dreamland.darkstar.lan (Postfix, from userid 1000) id 28BED70366; Sun, 18 Jan 2009 19:21:26 +0100 (CET) Date: Sun, 18 Jan 2009 19:21:26 +0100 From: Luca Tettamanti To: linux-media@vger.kernel.org Cc: Manu Abraham Subject: [PATCH] saa716x: fix pointer cast to 32bit Message-ID: <20090118182126.GA18750@dreamland.darkstar.lan> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Pointers may be 64bit long, casting them to u32 is wrong. For doing math on the address unsigned long is guaranteed to have to correct size to hold the value of the pointer. Signed-off-by: Luca Tettamanti --- linux/drivers/media/dvb/saa716x/saa716x_dma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Luca Index: b/linux/drivers/media/dvb/saa716x/saa716x_dma.c =================================================================== --- a/linux/drivers/media/dvb/saa716x/saa716x_dma.c 2009-01-18 19:13:35.126021813 +0100 +++ b/linux/drivers/media/dvb/saa716x/saa716x_dma.c 2009-01-18 19:15:34.074015003 +0100 @@ -34,7 +34,7 @@ return -ENOMEM; } - BUG_ON(!(((u32) dmabuf->mem_ptab_phys % SAA716x_PAGE_SIZE) == 0)); + BUG_ON(!(((unsigned long) dmabuf->mem_ptab_phys % SAA716x_PAGE_SIZE) == 0)); return 0; } @@ -126,9 +126,9 @@ } /* align memory to page */ - dmabuf->mem_virt = (void *) PAGE_ALIGN (((u32) dmabuf->mem_virt_noalign)); + dmabuf->mem_virt = (void *) PAGE_ALIGN (((unsigned long) dmabuf->mem_virt_noalign)); - BUG_ON(!((((u32) dmabuf->mem_virt) % SAA716x_PAGE_SIZE) == 0)); + BUG_ON(!((((unsigned long) dmabuf->mem_virt) % SAA716x_PAGE_SIZE) == 0)); } else { dmabuf->mem_virt = buf; }