| Message ID | 20090329124251.GF637@aniel (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Sun, Mar 29, 2009 at 8:42 AM, Janne Grunau <j@jannau.net> wrote:
>
Hello Janne,
I'm not against this change, but you should also get rid of the "i"
variable and the au0828_instance list (since the v4l2_device.name was
the only purpose for both).
Also, your subject didn't really match the function of the patch. Had
I not looked at the patch itself, I would have only thought you were
changing the v4l2_device_register().
Please put me on the CC: for anything related to au0828 analog
support, since I authored the code in question.
Thanks,
Devin
Hi Devin, On Sun, Mar 29, 2009 at 09:44:25AM -0400, Devin Heitmueller wrote: > On Sun, Mar 29, 2009 at 8:42 AM, Janne Grunau <j@jannau.net> wrote: > > > > I'm not against this change, but you should also get rid of the "i" > variable and the au0828_instance list (since the v4l2_device.name was > the only purpose for both). done > Also, your subject didn't really match the function of the patch. Had > I not looked at the patch itself, I would have only thought you were > changing the v4l2_device_register(). yeah, the subject was bad for au0828 and cx231xx but I had trouble to find find something better. I splitted the patches nao. > Please put me on the CC: for anything related to au0828 analog > support, since I authored the code in question. noted, Sorry I had only looked at the au0228-core.c header which notes only Steven. Janne -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
# HG changeset patch # User Janne Grunau <j@jannau.net> # Date 1238191025 -3600 # Node ID 16016db934ee03d0156754b8e07d4212c933d234 # Parent 210007cef5bdef2364590755a2b7ab219534db16 au0828: use usb_interface.dev for v4l2_device_register From: Janne Grunau <j@jannau.net> removes the explicitly set v4l2_device.name Priority: normal Signed-off-by: Janne Grunau <j@jannau.net> diff -r 210007cef5bd -r 16016db934ee linux/drivers/media/video/au0828/au0828-core.c --- a/linux/drivers/media/video/au0828/au0828-core.c Fri Mar 27 22:54:45 2009 +0100 +++ b/linux/drivers/media/video/au0828/au0828-core.c Fri Mar 27 22:57:05 2009 +0100 @@ -199,9 +199,7 @@ /* Create the v4l2_device */ i = atomic_inc_return(&au0828_instance) - 1; - snprintf(dev->v4l2_dev.name, sizeof(dev->v4l2_dev.name), "%s-%03d", - "au0828", i); - retval = v4l2_device_register(&dev->usbdev->dev, &dev->v4l2_dev); + retval = v4l2_device_register(&interface->dev, &dev->v4l2_dev); if (retval) { printk(KERN_ERR "%s() v4l2_device_register failed\n", __func__); -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html