From patchwork Wed Apr 1 02:03:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Beregalov X-Patchwork-Id: 15582 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3123dnm010379 for ; Wed, 1 Apr 2009 02:03:39 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754861AbZDACDi (ORCPT ); Tue, 31 Mar 2009 22:03:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754914AbZDACDi (ORCPT ); Tue, 31 Mar 2009 22:03:38 -0400 Received: from mail-fx0-f158.google.com ([209.85.220.158]:41283 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbZDACDh (ORCPT ); Tue, 31 Mar 2009 22:03:37 -0400 Received: by fxm2 with SMTP id 2so2716892fxm.37 for ; Tue, 31 Mar 2009 19:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=e3Oz3OMa8FwSltbrDXWLD+ZcxmLspwFPrdeblAZA7pk=; b=CBizpiqOLktXaciOhQPAyvaTDPCAgNNgorxQutIWoI0G9YPKUAysPAeJj7wigrpoEl 4Qgav3pMO4RDx/t3dVQ8BlaNHgOdT0gR9E+MX6IwbghVcRuw/YL+9zniuLvB2Hr0T4OY RzaMUcjqNmr81cCEXq+CpKFopmJzg2avNIYN4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=YbSGpIuN4zuHCO0frT0YmdQmeQssoqVlaywjeqlfoYulXTPxxKCCovoXxDGY087QzR swsIm1cWgfDxggZVVxNDWo0owq4D+6s8U63pOCkrkRj3OH8INYkx9mHc0c1Fe8S0Ua2F e6f7MOTz5s7adc0RZGjCnxWJ/DpPtMO93ibC4= Received: by 10.204.58.9 with SMTP id e9mr2606937bkh.15.1238551413626; Tue, 31 Mar 2009 19:03:33 -0700 (PDT) Received: from orion (ppp91-76-230-215.pppoe.mtu-net.ru [91.76.230.215]) by mx.google.com with ESMTPS id 12sm3180342fks.5.2009.03.31.19.03.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 31 Mar 2009 19:03:33 -0700 (PDT) Date: Wed, 1 Apr 2009 06:03:27 +0400 From: Alexander Beregalov To: linux-next@vger.kernel.org, mchehab@infradead.org, linux-media@vger.kernel.org, srinivasa.deevi@conexant.com Subject: [PATCH] cx231xx: fix wrong usage of select in kconfig Message-ID: <20090401020327.GA6808@orion> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org VIDEO_CX231XX_ALSA depends on SND && SND_PCM, but if we select it from VIDEO_CX231XX entry it does not automatically select SND_PCM. It causes build error: ERROR: "snd_pcm_period_elapsed" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! Documentation/kbuild/kconfig-language.txt: Note: select should be used with care. select will force a symbol to a value without visiting the dependencies. By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set. Signed-off-by: Alexander Beregalov --- drivers/media/video/cx231xx/Kconfig | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/cx231xx/Kconfig b/drivers/media/video/cx231xx/Kconfig index 9115654..85ae751 100644 --- a/drivers/media/video/cx231xx/Kconfig +++ b/drivers/media/video/cx231xx/Kconfig @@ -6,7 +6,6 @@ config VIDEO_CX231XX select VIDEO_IR select VIDEOBUF_VMALLOC select VIDEO_CX25840 - select VIDEO_CX231XX_ALSA ---help--- This is a video4linux driver for Conexant 231xx USB based TV cards.