From patchwork Wed Apr 22 02:25:19 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 19302 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3M2PXEl024009 for ; Wed, 22 Apr 2009 02:25:33 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753142AbZDVCZb (ORCPT ); Tue, 21 Apr 2009 22:25:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754341AbZDVCZb (ORCPT ); Tue, 21 Apr 2009 22:25:31 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:38485 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754012AbZDVCZ3 (ORCPT ); Tue, 21 Apr 2009 22:25:29 -0400 Received: from 187-27-221-229.3g.claro.net.br ([187.27.221.229] helo=pedra.chehab.org) by bombadil.infradead.org with esmtpsa (Exim 4.69 #1 (Red Hat Linux)) id 1LwS9J-0008KV-Kn; Wed, 22 Apr 2009 02:25:24 +0000 Date: Tue, 21 Apr 2009 23:25:19 -0300 From: Mauro Carvalho Chehab To: vaka@newmail.ru Cc: hermann pitton , akpm@linux-foundation.org, mm-commits@vger.kernel.org, mkrufky@linuxtv.org, hartmut.hackmann@t-online.de, linux-media@vger.kernel.org Subject: Re: + drivers-media-video-saa7134-add-tuner-support-for-avermedia-studio-505.patch added to -mm tree Message-ID: <20090421232519.51365265@pedra.chehab.org> In-Reply-To: <1240356078.22263.33.camel@pc07.localdom.local> References: <200904202021.n3KKLGvd000469@imap1.linux-foundation.org> <1240356078.22263.33.camel@pc07.localdom.local> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.10.4; x86_64-redhat-linux-gnu) Mime-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, 22 Apr 2009 01:21:18 +0200 hermann pitton wrote: > Vasily, your change in saa7134-video.c has broken support for all other > SECAM standards and users can't change them from the applications > anymore. > > After years of trouble, it has very good reasons that we have it as it > is and it was a lot of work to make it usable for all, since different > Secam auto detection through the tvaudio kernelthread turned out to be > impossible. > > Here is Hartmut's original patch, on which you touch, after working for > a weekend with a signal generator to find a resolution suitable for all. > http://linuxtv.org/hg/v4l-dvb/rev/84a832a5ffc9 The trouble pointed by Hermann is caused by this hunk: Agreed. The boards are ordered by number, not by name. Since the board number should be unique, ordering by something else will likely create duplicate numbers. Cheers, Mauro --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -puN drivers/media/video/saa7134/saa7134-video.c~drivers-media-video-saa7134-add-tuner-support-for-avermedia-studio-505 drivers/media/video/saa7134/saa7134-video.c --- a/drivers/media/video/saa7134/saa7134-video.c~drivers-media-video-saa7134-add-tuner-support-for-avermedia-studio-505 +++ a/drivers/media/video/saa7134/saa7134-video.c @@ -39,7 +39,7 @@ static unsigned int gbuffers = 8; static unsigned int noninterlaced; /* 0 */ static unsigned int gbufsize = 720*576*4; static unsigned int gbufsize_max = 720*576*4; -static char secam[] = "--"; +static char secam[] = "dk"; module_param(video_debug, int, 0644); MODULE_PARM_DESC(video_debug,"enable debug messages [video]"); module_param(gbuffers, int, 0444); This disables SECAM autodetection, forcing the driver to use SECAM/DK. Just removing this will fix this issue. > Also please don't jump around with the card #define in saa7134.h. > We keep it there like they historically do appear. --- a/drivers/media/video/saa7134/saa7134.h~drivers-media-video-saa7134-add-tuner-support-for-avermedia-studio-505 +++ a/drivers/media/video/saa7134/saa7134.h @@ -159,6 +159,7 @@ struct saa7134_format { #define SAA7134_BOARD_AVERMEDIA_DVD_EZMAKER 33 #define SAA7134_BOARD_NOVAC_PRIMETV7133 34 #define SAA7134_BOARD_AVERMEDIA_STUDIO_305 35 +#define SAA7134_BOARD_AVERMEDIA_STUDIO_505 158 #define SAA7134_BOARD_UPMOST_PURPLE_TV 36 #define SAA7134_BOARD_ITEMS_MTV005 37 #define SAA7134_BOARD_CINERGY200 38