diff mbox

radio_si470x: Drop unused label

Message ID 200904301616.23303.nsoranzo@tiscali.it (mailing list archive)
State Superseded
Headers show

Commit Message

Nicola Soranzo April 30, 2009, 2:16 p.m. UTC 
Fix this warning:

/home/nicola/v4l-dvb/v4l/radio-si470x.c: In function 'si470x_fops_release':
/home/nicola/v4l-dvb/v4l/radio-si470x.c:1218: warning: label 'unlock' defined but not used

Priority: normal

Signed-off-by: Nicola Soranzo <nsoranzo@tiscali.it>

---

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Alexey Klimov April 30, 2009, 7:43 p.m. UTC | #1 
(added Tobias and Mauro on c/c)

On Thu, Apr 30, 2009 at 6:16 PM, Nicola Soranzo <nsoranzo@tiscali.it> wrote:
> Fix this warning:
>
> /home/nicola/v4l-dvb/v4l/radio-si470x.c: In function 'si470x_fops_release':
> /home/nicola/v4l-dvb/v4l/radio-si470x.c:1218: warning: label 'unlock' defined but not used
>
> Priority: normal
>
> Signed-off-by: Nicola Soranzo <nsoranzo@tiscali.it>
>
> ---
> diff -r 83712d149893 -r 97be9e920832 linux/drivers/media/radio/radio-si470x.c
> --- a/linux/drivers/media/radio/radio-si470x.c  Wed Apr 29 18:01:48 2009 -0300
> +++ b/linux/drivers/media/radio/radio-si470x.c  Thu Apr 30 16:10:24 2009 +0200
> @@ -1214,8 +1214,6 @@
>                retval = si470x_stop(radio);
>                usb_autopm_put_interface(radio->intf);
>        }
> -
> -unlock:
>        mutex_unlock(&radio->disconnect_lock);
>
>  done:

Looks good. Thank you.
When i built latest up-to-date git kernel i noticed that this warning
showed there also.
Probably, it's better this patch reach 2.6.30 kernel. Now we are at rc4.
diff mbox

Patch

diff -r 83712d149893 -r 97be9e920832 linux/drivers/media/radio/radio-si470x.c
--- a/linux/drivers/media/radio/radio-si470x.c	Wed Apr 29 18:01:48 2009 -0300
+++ b/linux/drivers/media/radio/radio-si470x.c	Thu Apr 30 16:10:24 2009 +0200
@@ -1214,8 +1214,6 @@ 
 		retval = si470x_stop(radio);
 		usb_autopm_put_interface(radio->intf);
 	}
-
-unlock:
 	mutex_unlock(&radio->disconnect_lock);
 
 done: