| Message ID | 200905122058.n4CKwg2m004390@imap1.linux-foundation.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Wed, May 13, 2009 at 12:39 AM, <akpm@linux-foundation.org> wrote: > From: Alessio Igor Bogani <abogani@texware.it> > > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be > pulled in indirectly by one of the headers it already includes, the right > thing is to include it directly. > > Signed-off-by: Alessio Igor Bogani <abogani@texware.it> > Cc: Mauro Carvalho Chehab <mchehab@infradead.org> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > --- > > Â drivers/media/radio/radio-mr800.c | Â Â 1 + > Â 1 file changed, 1 insertion(+) > > diff -puN drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include drivers/media/radio/radio-mr800.c > --- a/drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include > +++ a/drivers/media/radio/radio-mr800.c > @@ -64,6 +64,7 @@ > Â #include <media/v4l2-ioctl.h> > Â #include <linux/usb.h> > Â #include <linux/version.h> Â Â /* for KERNEL_VERSION MACRO */ > +#include <linux/mutex.h> > > Â /* driver and module definitions */ > Â #define DRIVER_AUTHOR "Alexey Klimov <klimov.linux@gmail.com>" > _ There was discussion about this patch. http://www.mail-archive.com/linux-media@vger.kernel.org/msg03556.html Well, i'm not against this patch.
diff -puN drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include drivers/media/radio/radio-mr800.c --- a/drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include +++ a/drivers/media/radio/radio-mr800.c @@ -64,6 +64,7 @@ #include <media/v4l2-ioctl.h> #include <linux/usb.h> #include <linux/version.h> /* for KERNEL_VERSION MACRO */ +#include <linux/mutex.h> /* driver and module definitions */ #define DRIVER_AUTHOR "Alexey Klimov <klimov.linux@gmail.com>"