From patchwork Thu Jun 4 19:18:13 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lennart Poettering X-Patchwork-Id: 28010 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n54JTHFv007756 for ; Thu, 4 Jun 2009 19:29:18 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752390AbZFDT3H (ORCPT ); Thu, 4 Jun 2009 15:29:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752594AbZFDT3H (ORCPT ); Thu, 4 Jun 2009 15:29:07 -0400 Received: from tango.0pointer.de ([85.214.72.216]:60217 "EHLO tango.0pointer.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbZFDT3H (ORCPT ); Thu, 4 Jun 2009 15:29:07 -0400 Received: by tango.0pointer.de (Postfix, from userid 1000) id 0D6B613270; Thu, 4 Jun 2009 21:18:14 +0200 (CEST) Date: Thu, 4 Jun 2009 21:18:13 +0200 From: Lennart Poettering To: linux-kernel@vger.kernel.org Cc: Andrew Morton , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH] V4L/pwc - use usb_interface as parent, not usb_device Message-ID: <20090604191813.GA6281@tango.0pointer.de> MIME-Version: 1.0 Content-Disposition: inline Organization: Red Hat, Inc. User-Agent: Leviathan/19.8.0 [zh] (Cray 3; I; Solaris 4.711; Console) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The current code creates a sysfs device path where the video4linux device is child of the usb device itself instead of the interface it belongs to. That is evil and confuses udev. This patch does basically the same thing as Kay's similar patch for the ov511 driver: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ce96d0a44a4f8d1bb3dc12b5e98cb688c1bc730d (Resent 2nd time, due to missing Signed-off-by) Lennart Signed-off-by: Lennart Poettering Acked-by: Hans de Goede --- drivers/media/video/pwc/pwc-if.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c index 7c542ca..92d4177 100644 --- a/drivers/media/video/pwc/pwc-if.c +++ b/drivers/media/video/pwc/pwc-if.c @@ -1783,7 +1783,7 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id return -ENOMEM; } memcpy(pdev->vdev, &pwc_template, sizeof(pwc_template)); - pdev->vdev->parent = &(udev->dev); + pdev->vdev->parent = &intf->dev; strcpy(pdev->vdev->name, name); video_set_drvdata(pdev->vdev, pdev);