| Message ID | 20090719145936.0c21917f@hyperion.delvare (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Douglas Landgraf |
| Headers | show |
On Sun, 2009-07-19 at 14:59 +0200, Jean Delvare wrote: > Functions which are referenced by their address can't be inlined by > definition. > > Signed-off-by: Jean Delvare <khali@linux-fr.org> Jean, Looks godd to me, but you forgot to add [PATCH] to the subject. I'll add this one to my revised patch set I submit to the list, unless you object. Regards, Andy > --- > linux/drivers/media/video/ir-kbd-i2c.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- v4l-dvb.orig/linux/drivers/media/video/ir-kbd-i2c.c 2009-07-19 14:30:29.000000000 +0200 > +++ v4l-dvb/linux/drivers/media/video/ir-kbd-i2c.c 2009-07-19 14:50:30.000000000 +0200 > @@ -127,12 +127,12 @@ static int get_key_haup_common(struct IR > return 1; > } > > -static inline int get_key_haup(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw) > +static int get_key_haup(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw) > { > return get_key_haup_common (ir, ir_key, ir_raw, 3, 0); > } > > -static inline int get_key_haup_xvr(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw) > +static int get_key_haup_xvr(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw) > { > return get_key_haup_common (ir, ir_key, ir_raw, 6, 3); > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 20 Jul 2009 20:09:44 -0400, Andy Walls wrote: > On Sun, 2009-07-19 at 14:59 +0200, Jean Delvare wrote: > > Functions which are referenced by their address can't be inlined by > > definition. > > > > Signed-off-by: Jean Delvare <khali@linux-fr.org> > > Jean, > > Looks godd to me, but you forgot to add [PATCH] to the subject. I'll > add this one to my revised patch set I submit to the list, unless you > object. Oops, you're right. Yes, please pick it up and push it forward, thanks!
--- v4l-dvb.orig/linux/drivers/media/video/ir-kbd-i2c.c 2009-07-19 14:30:29.000000000 +0200 +++ v4l-dvb/linux/drivers/media/video/ir-kbd-i2c.c 2009-07-19 14:50:30.000000000 +0200 @@ -127,12 +127,12 @@ static int get_key_haup_common(struct IR return 1; } -static inline int get_key_haup(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw) +static int get_key_haup(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw) { return get_key_haup_common (ir, ir_key, ir_raw, 3, 0); } -static inline int get_key_haup_xvr(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw) +static int get_key_haup_xvr(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw) { return get_key_haup_common (ir, ir_key, ir_raw, 6, 3); }
Functions which are referenced by their address can't be inlined by definition. Signed-off-by: Jean Delvare <khali@linux-fr.org> --- linux/drivers/media/video/ir-kbd-i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)