From patchwork Thu Nov 26 00:02:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 63024 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nAQ02qVZ013949 for ; Thu, 26 Nov 2009 00:02:52 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759585AbZKZACo (ORCPT ); Wed, 25 Nov 2009 19:02:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759516AbZKZACo (ORCPT ); Wed, 25 Nov 2009 19:02:44 -0500 Received: from perceval.irobotique.be ([92.243.18.41]:52471 "EHLO perceval.irobotique.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753438AbZKZACo (ORCPT ); Wed, 25 Nov 2009 19:02:44 -0500 Received: from ravenclaw.localnet (36.102-243-81.adsl-dyn.isp.belgacom.be [81.243.102.36]) by perceval.irobotique.be (Postfix) with ESMTPSA id AA77635AEE; Thu, 26 Nov 2009 00:02:45 +0000 (UTC) From: Laurent Pinchart To: Devin Heitmueller Subject: Re: [PATCH/RFC v2] V4L core cleanups HG tree Date: Thu, 26 Nov 2009 01:02:40 +0100 User-Agent: KMail/1.12.3 (Linux/2.6.31.1; KDE/4.3.3; x86_64; ; ) Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl, mchehab@infradead.org, sakari.ailus@maxwell.research.nokia.com References: <200911181354.06529.laurent.pinchart@ideasonboard.com> <829197380911251506g4af4d72v85c6dfb55cb88d0a@mail.gmail.com> In-Reply-To: <829197380911251506g4af4d72v85c6dfb55cb88d0a@mail.gmail.com> MIME-Version: 1.0 Message-Id: <200911260102.40881.laurent.pinchart@ideasonboard.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org diff -r 98e3929a1a2d linux/drivers/media/video/au0828/au0828-video.c --- a/linux/drivers/media/video/au0828/au0828-video.c Wed Nov 25 12:55:47 2009 +0100 +++ b/linux/drivers/media/video/au0828/au0828-video.c Thu Nov 26 01:02:15 2009 +0100 @@ -697,10 +697,8 @@ dprintk(1, "au0828_release_resources called\n"); mutex_lock(&au0828_sysfs_lock); - if (dev->vdev) { - list_del(&dev->au0828list); + if (dev->vdev) video_unregister_device(dev->vdev); - } if (dev->vbi_dev) video_unregister_device(dev->vbi_dev); @@ -1671,7 +1669,6 @@ if (retval != 0) { dprintk(1, "unable to register video device (error = %d).\n", retval); - list_del(&dev->au0828list); video_device_release(dev->vdev); return -ENODEV; } @@ -1683,7 +1680,6 @@ if (retval != 0) { dprintk(1, "unable to register vbi device (error = %d).\n", retval); - list_del(&dev->au0828list); video_device_release(dev->vbi_dev); video_device_release(dev->vdev); return -ENODEV; diff -r 98e3929a1a2d linux/drivers/media/video/au0828/au0828.h --- a/linux/drivers/media/video/au0828/au0828.h Wed Nov 25 12:55:47 2009 +0100 +++ b/linux/drivers/media/video/au0828/au0828.h Thu Nov 26 01:02:15 2009 +0100 @@ -192,7 +192,6 @@ struct au0828_dvb dvb; /* Analog */ - struct list_head au0828list; struct v4l2_device v4l2_dev; int users; unsigned int stream_on:1; /* Locks streams */