From patchwork Tue Apr 6 16:25:11 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 90801 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o36GPIlW013881 for ; Tue, 6 Apr 2010 16:25:18 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756281Ab0DFQZQ (ORCPT ); Tue, 6 Apr 2010 12:25:16 -0400 Received: from bamako.nerim.net ([62.4.17.28]:57632 "EHLO bamako.nerim.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755678Ab0DFQZO (ORCPT ); Tue, 6 Apr 2010 12:25:14 -0400 Received: from localhost (localhost [127.0.0.1]) by bamako.nerim.net (Postfix) with ESMTP id 43B5B39DE63; Tue, 6 Apr 2010 18:25:11 +0200 (CEST) X-Virus-Scanned: amavisd-new at nerim.net Received: from bamako.nerim.net ([127.0.0.1]) by localhost (bamako.nerim.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pUQaKyxP3IGq; Tue, 6 Apr 2010 18:25:10 +0200 (CEST) Received: from hyperion.delvare (jdelvare.pck.nerim.net [62.212.121.182]) by bamako.nerim.net (Postfix) with ESMTP id E24EB39DE73; Tue, 6 Apr 2010 18:25:09 +0200 (CEST) Date: Tue, 6 Apr 2010 18:25:11 +0200 From: Jean Delvare To: Mauro Carvalho Chehab Cc: Linux I2C , LMML Subject: Re: [PATCH 2/2] V4L/DVB: Use custom I2C probing function mechanism Message-ID: <20100406182511.62894659@hyperion.delvare> In-Reply-To: <4BBAC7F6.5030807@redhat.com> References: <20100404161454.0f99cc06@hyperion.delvare> <4BBA2B58.4000007@redhat.com> <20100405230616.443792ac@hyperion.delvare> <4BBAC7F6.5030807@redhat.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; i586-suse-linux-gnu) Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 06 Apr 2010 16:25:19 +0000 (UTC) --- linux-2.6.34-rc3.orig/drivers/media/video/cx23885/cx23885-i2c.c 2010-04-06 11:31:20.000000000 +0200 +++ linux-2.6.34-rc3/drivers/media/video/cx23885/cx23885-i2c.c 2010-04-06 12:28:09.000000000 +0200 @@ -365,17 +365,10 @@ int cx23885_i2c_register(struct cx23885_ memset(&info, 0, sizeof(struct i2c_board_info)); strlcpy(info.type, "ir_video", I2C_NAME_SIZE); - /* - * We can't call i2c_new_probed_device() because it uses - * quick writes for probing and the IR receiver device only - * replies to reads. - */ - if (i2c_smbus_xfer(&bus->i2c_adap, addr_list[0], 0, - I2C_SMBUS_READ, 0, I2C_SMBUS_QUICK, - NULL) >= 0) { - info.addr = addr_list[0]; - i2c_new_device(&bus->i2c_adap, &info); - } + /* Use quick read command for probe, some IR chips don't + * support writes */ + i2c_new_probed_device(&bus->i2c_adap, &info, addr_list, + i2c_probe_func_quick_read); } return bus->i2c_rc; --- linux-2.6.34-rc3.orig/drivers/media/video/cx88/cx88-i2c.c 2010-04-06 11:31:20.000000000 +0200 +++ linux-2.6.34-rc3/drivers/media/video/cx88/cx88-i2c.c 2010-04-06 12:28:06.000000000 +0200 @@ -188,24 +188,13 @@ int cx88_i2c_init(struct cx88_core *core 0x18, 0x6b, 0x71, I2C_CLIENT_END }; - const unsigned short *addrp; memset(&info, 0, sizeof(struct i2c_board_info)); strlcpy(info.type, "ir_video", I2C_NAME_SIZE); - /* - * We can't call i2c_new_probed_device() because it uses - * quick writes for probing and at least some R receiver - * devices only reply to reads. - */ - for (addrp = addr_list; *addrp != I2C_CLIENT_END; addrp++) { - if (i2c_smbus_xfer(&core->i2c_adap, *addrp, 0, - I2C_SMBUS_READ, 0, - I2C_SMBUS_QUICK, NULL) >= 0) { - info.addr = *addrp; - i2c_new_device(&core->i2c_adap, &info); - break; - } - } + /* Use quick read command for probe, some IR chips don't + * support writes */ + i2c_new_probed_device(&core->i2c_adap, &info, addr_list, + i2c_probe_func_quick_read); } return core->i2c_rc; } --- linux-2.6.34-rc3.orig/drivers/i2c/i2c-core.c 2010-04-06 10:15:02.000000000 +0200 +++ linux-2.6.34-rc3/drivers/i2c/i2c-core.c 2010-04-06 12:25:31.000000000 +0200 @@ -1460,6 +1460,13 @@ static int i2c_default_probe(struct i2c_ return err >= 0; } +int i2c_probe_func_quick_read(struct i2c_adapter *i2c, unsigned short addr) +{ + return i2c_smbus_xfer(i2c, addr, 0, I2C_SMBUS_READ, 0, + I2C_SMBUS_QUICK, NULL) >= 0; +} +EXPORT_SYMBOL_GPL(i2c_probe_func_quick_read); + struct i2c_client * i2c_new_probed_device(struct i2c_adapter *adap, struct i2c_board_info *info, --- linux-2.6.34-rc3.orig/include/linux/i2c.h 2010-04-06 10:15:02.000000000 +0200 +++ linux-2.6.34-rc3/include/linux/i2c.h 2010-04-06 12:26:29.000000000 +0200 @@ -288,6 +288,9 @@ i2c_new_probed_device(struct i2c_adapter unsigned short const *addr_list, int (*probe)(struct i2c_adapter *, unsigned short addr)); +/* common custom probe functions */ +extern int i2c_probe_func_quick_read(struct i2c_adapter *, unsigned short addr); + /* For devices that use several addresses, use i2c_new_dummy() to make * client handles for the extra addresses. */