From patchwork Fri May 7 07:05:15 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guy Martin X-Patchwork-Id: 97603 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4775GfW018274 for ; Fri, 7 May 2010 07:05:16 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752145Ab0EGHFO (ORCPT ); Fri, 7 May 2010 03:05:14 -0400 Received: from smtp2.tech.numericable.fr ([82.216.111.38]:52086 "EHLO smtp2.tech.numericable.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499Ab0EGHFN (ORCPT ); Fri, 7 May 2010 03:05:13 -0400 Received: from ibiza.bxl.tuxicoman.be (cable-85.28.107.20.coditel.net [85.28.107.20]) by smtp2.tech.numericable.fr (Postfix) with ESMTP id 5184818D806; Fri, 7 May 2010 09:05:10 +0200 (CEST) Received: from [172.22.0.10] (helo=zombie) by ibiza.bxl.tuxicoman.be with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1OAHcR-0004zA-Tx; Fri, 07 May 2010 09:05:10 +0200 Date: Fri, 7 May 2010 09:05:15 +0200 From: Guy Martin To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Subject: Re: [PATCH] stv6110x Fix kernel null pointer deref when plugging two TT s2-1600 Message-ID: <20100507090515.2fb971a7@zombie> In-Reply-To: <20100503230924.3f560423@pedra> References: <20100411231529.1538cf69@borg.bxl.tuxicoman.be> <20100503230924.3f560423@pedra> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.7; x86_64-pc-linux-gnu) Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Fri, 07 May 2010 07:05:16 +0000 (UTC) diff -r 4a8d6d981f07 linux/drivers/media/dvb/frontends/stv6110x.c --- a/linux/drivers/media/dvb/frontends/stv6110x.c Wed May 05 11:58:44 2010 -0300 +++ b/linux/drivers/media/dvb/frontends/stv6110x.c Fri May 07 08:51:18 2010 +0200 @@ -302,7 +302,10 @@ static int stv6110x_sleep(struct dvb_frontend *fe) { - return stv6110x_set_mode(fe, TUNER_SLEEP); + if (fe->tuner_priv) + return stv6110x_set_mode(fe, TUNER_SLEEP); + + return 0; } static int stv6110x_get_status(struct dvb_frontend *fe, u32 *status) diff -r 4a8d6d981f07 linux/drivers/media/dvb/ttpci/budget.c --- a/linux/drivers/media/dvb/ttpci/budget.c Wed May 05 11:58:44 2010 -0300 +++ b/linux/drivers/media/dvb/ttpci/budget.c Fri May 07 08:51:18 2010 +0200 @@ -461,8 +461,8 @@ }; static struct isl6423_config tt1600_isl6423_config = { - .current_max = SEC_CURRENT_515m, - .curlim = SEC_CURRENT_LIM_ON, + .current_max = SEC_CURRENT_800m, + .curlim = SEC_CURRENT_LIM_OFF, .mod_extern = 1, .addr = 0x08, };