From patchwork Mon Dec 13 15:59:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: iceberg X-Patchwork-Id: 407012 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oBDFxodl023661 for ; Mon, 13 Dec 2010 15:59:50 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757482Ab0LMP7Z (ORCPT ); Mon, 13 Dec 2010 10:59:25 -0500 Received: from smtp.ispras.ru ([83.149.198.201]:36692 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917Ab0LMP7Y convert rfc822-to-8bit (ORCPT ); Mon, 13 Dec 2010 10:59:24 -0500 X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Mon, 13 Dec 2010 15:59:50 +0000 (UTC) X-Greylist: delayed 1141 seconds by postgrey-1.27 at vger.kernel.org; Mon, 13 Dec 2010 10:59:24 EST Received: from pamir.localnet (unknown [83.149.198.236]) by smtp.ispras.ru (Postfix) with ESMTP id 2C53F5D40B5; Mon, 13 Dec 2010 18:34:28 +0300 (MSK) From: Alexander Strakh Organization: ISP RAS To: linux-kernel@vger.kernel.org, kangyong@telegent.com, xbzhang@telegent.com, zyziii@telegent.com, shijie8@gmail.com, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: BUG: double mutex_unlock in drivers/media/video/tlg2300/pd-video.c Date: Mon, 13 Dec 2010 18:59:14 +0300 User-Agent: KMail/1.13.5 (Linux/2.6.34-12-desktop; KDE/4.4.4; x86_64; ; ) MIME-Version: 1.0 Message-Id: <201012131859.15152.strakh@ispras.ru> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c index a1ffe18..fe6bd2b 100644 --- a/drivers/media/video/tlg2300/pd-video.c +++ b/drivers/media/video/tlg2300/pd-video.c @@ -802,8 +802,8 @@ static int vidioc_s_fmt(struct file *file, void *fh, struct v4l2_format *f) return -EINVAL; } - pd_vidioc_s_fmt(pd, &f->fmt.pix); - mutex_unlock(&pd->lock); + if(!pd_vidioc_s_fmt(pd, &f->fmt.pix)) + mutex_unlock(&pd->lock); return 0; }