From patchwork Fri Jan 21 09:15:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: iceberg X-Patchwork-Id: 494541 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0L9TFSg012698 for ; Fri, 21 Jan 2011 09:29:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750830Ab1AUJ2u (ORCPT ); Fri, 21 Jan 2011 04:28:50 -0500 Received: from smtp.ispras.ru ([83.149.198.201]:40121 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710Ab1AUJ2t (ORCPT ); Fri, 21 Jan 2011 04:28:49 -0500 X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 21 Jan 2011 09:29:15 +0000 (UTC) X-Greylist: delayed 1786 seconds by postgrey-1.27 at vger.kernel.org; Fri, 21 Jan 2011 04:28:48 EST Received: from pamir.localnet (winnie.ispras.ru [83.149.198.236]) by smtp.ispras.ru (Postfix) with ESMTP id A36755D40F7; Fri, 21 Jan 2011 11:50:22 +0300 (MSK) From: Alexander Strakh Organization: ISP RAS To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Fwd: Re: BUG: double mutex_unlock in drivers/media/video/tlg2300/pd-video.c Date: Fri, 21 Jan 2011 12:15:51 +0300 User-Agent: KMail/1.13.5 (Linux/2.6.34.7-0.7-desktop; KDE/4.4.4; x86_64; ; ) MIME-Version: 1.0 Message-Id: <201101211215.51322.strakh@ispras.ru> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c index a1ffe18..6eb4538 100644 --- a/drivers/media/video/tlg2300/pd-video.c +++ b/drivers/media/video/tlg2300/pd-video.c @@ -763,10 +763,8 @@ static int pd_vidioc_s_fmt(struct poseidon *pd, struct v4l2_pix_format *pix) } ret |= send_set_req(pd, VIDEO_ROSOLU_SEL, vid_resol, &cmd_status); - if (ret || cmd_status) { - mutex_unlock(&pd->lock); + if (ret || cmd_status) return -EBUSY; - } pix_def->pixelformat = pix->pixelformat; /* save it */