From patchwork Tue Feb 22 07:53:59 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 579581 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p1M7se4u020602 for ; Tue, 22 Feb 2011 07:54:40 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753942Ab1BVHy0 (ORCPT ); Tue, 22 Feb 2011 02:54:26 -0500 Received: from smtp-vbr11.xs4all.nl ([194.109.24.31]:4609 "EHLO smtp-vbr11.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753841Ab1BVHyZ (ORCPT ); Tue, 22 Feb 2011 02:54:25 -0500 Received: from tschai.localnet (105.84-48-119.nextgentel.com [84.48.119.105]) (authenticated bits=0) by smtp-vbr11.xs4all.nl (8.13.8/8.13.8) with ESMTP id p1M7s4Ux093097 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Feb 2011 08:54:06 +0100 (CET) (envelope-from hverkuil@xs4all.nl) From: Hans Verkuil To: Mauro Carvalho Chehab Subject: Re: [PATCH 0/4] Some fixes for tuner, tvp5150 and em28xx Date: Tue, 22 Feb 2011 08:53:59 +0100 User-Agent: KMail/1.13.5 (Linux/2.6.38-rc2-tschai; KDE/4.4.5; x86_64; ; ) Cc: Linux Media Mailing List References: <20110221231741.71a2149e@pedra> <4D6324DB.5030801@redhat.com> In-Reply-To: <4D6324DB.5030801@redhat.com> MIME-Version: 1.0 Message-Id: <201102220853.59343.hverkuil@xs4all.nl> X-Virus-Scanned: by XS4ALL Virus Scanner Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 22 Feb 2011 07:54:40 +0000 (UTC) different bug relating to the handling of V4L2_CTRL_FLAG_NEXT_CTRL. Can you try this patch: diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c index ef66d2a..15eda86 100644 --- a/drivers/media/video/v4l2-ctrls.c +++ b/drivers/media/video/v4l2-ctrls.c @@ -1364,6 +1364,8 @@ EXPORT_SYMBOL(v4l2_queryctrl); int v4l2_subdev_queryctrl(struct v4l2_subdev *sd, struct v4l2_queryctrl *qc) { + if (qc->id & V4L2_CTRL_FLAG_NEXT_CTRL) + return -EINVAL; return v4l2_queryctrl(sd->ctrl_handler, qc); } EXPORT_SYMBOL(v4l2_subdev_queryctrl);