diff mbox

Make nchg variable signed because the code compares this variable against negative values.

Message ID 201105231309.54265.hselasky@c2i.net (mailing list archive)
State Accepted
Headers show

Commit Message

Hans Petter Selasky May 23, 2011, 11:09 a.m. UTC 
--HPS

Comments

Mauro Carvalho Chehab May 26, 2011, 12:07 a.m. UTC | #1 
Jean-François,

This patch looks ok to me, although the description is not 100%. 

The sonixj driver compares the value for nchg with
		if (sd->nchg < -6 || sd->nchg >= 12) {

With u8, negative values won't work.

Please check.

Thanks!
Mauro



Em 23-05-2011 08:09, Hans Petter Selasky escreveu:
> --HPS
> 
> 
> dvb-usb-0006.patch
> 
> 
> From b05d4913df24f11c7b7a2e07201bb87a04a949bc Mon Sep 17 00:00:00 2001
> From: Hans Petter Selasky <hselasky@c2i.net>
> Date: Mon, 23 May 2011 13:09:18 +0200
> Subject: [PATCH] Make nchg variable signed because the code compares this variable against negative values.
> 
> Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
> ---
>  drivers/media/video/gspca/sonixj.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c
> index 6415aff..81b8a60 100644
> --- a/drivers/media/video/gspca/sonixj.c
> +++ b/drivers/media/video/gspca/sonixj.c
> @@ -60,7 +60,7 @@ struct sd {
>  
>  	u32 pktsz;			/* (used by pkt_scan) */
>  	u16 npkt;
> -	u8 nchg;
> +	s8 nchg;
>  	s8 short_mark;
>  
>  	u8 quality;			/* image quality */
> -- 1.7.1.1


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jean-Francois Moine May 26, 2011, 6:48 a.m. UTC | #2 
On Wed, 25 May 2011 21:07:17 -0300
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:

> This patch looks ok to me, although the description is not 100%. 
> 
> The sonixj driver compares the value for nchg with
> 		if (sd->nchg < -6 || sd->nchg >= 12) {
> 
> With u8, negative values won't work.
> 
> Please check.

Hi Mauro and Hans Petter,

With all the messages in the list, I did not noticed this patch.

Indeed, the fix is correct. I was wondering why there were still
problems with the image size in sonixj. They should disappear now.

Thanks.
diff mbox

Patch

From b05d4913df24f11c7b7a2e07201bb87a04a949bc Mon Sep 17 00:00:00 2001
From: Hans Petter Selasky <hselasky@c2i.net>
Date: Mon, 23 May 2011 13:09:18 +0200
Subject: [PATCH] Make nchg variable signed because the code compares this variable against negative values.

Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
---
 drivers/media/video/gspca/sonixj.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c
index 6415aff..81b8a60 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -60,7 +60,7 @@  struct sd {
 
 	u32 pktsz;			/* (used by pkt_scan) */
 	u16 npkt;
-	u8 nchg;
+	s8 nchg;
 	s8 short_mark;
 
 	u8 quality;			/* image quality */
-- 
1.7.1.1