diff mbox

Define parameter description after the parameter itself.

Message ID 201105231327.11791.hselasky@c2i.net (mailing list archive)
State Changes Requested
Headers show

Commit Message

Hans Petter Selasky May 23, 2011, 11:27 a.m. UTC
--HPS

Comments

Mauro Carvalho Chehab May 26, 2011, 12:13 a.m. UTC | #1
Em 23-05-2011 08:27, Hans Petter Selasky escreveu:
> --HPS
> 
> 
> dvb-usb-0008.patch
> 
> 
> From 2f5378e5c5cc5528473f77321879fb075005d3dd Mon Sep 17 00:00:00 2001
> From: Hans Petter Selasky <hselasky@c2i.net>
> Date: Mon, 23 May 2011 13:26:04 +0200
> Subject: [PATCH] Define parameter description after the parameter itself.
> 
> Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
> ---
>  drivers/media/video/tda7432.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/tda7432.c b/drivers/media/video/tda7432.c
> index 3941f95..398b9fb 100644
> --- a/drivers/media/video/tda7432.c
> +++ b/drivers/media/video/tda7432.c
> @@ -50,8 +50,8 @@ static int loudness; /* disable loudness by default */
>  static int debug;	 /* insmod parameter */
>  module_param(debug, int, S_IRUGO | S_IWUSR);
>  module_param(loudness, int, S_IRUGO);
> -MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");
>  module_param(maxvol, int, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");

Ok, but this doesn't change the fact that debug and loudness aren't commented.
Could you please also add descriptions for those parameters where no descriptions
were provided? 

Thanks!
Mauro.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

From 2f5378e5c5cc5528473f77321879fb075005d3dd Mon Sep 17 00:00:00 2001
From: Hans Petter Selasky <hselasky@c2i.net>
Date: Mon, 23 May 2011 13:26:04 +0200
Subject: [PATCH] Define parameter description after the parameter itself.

Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
---
 drivers/media/video/tda7432.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/tda7432.c b/drivers/media/video/tda7432.c
index 3941f95..398b9fb 100644
--- a/drivers/media/video/tda7432.c
+++ b/drivers/media/video/tda7432.c
@@ -50,8 +50,8 @@  static int loudness; /* disable loudness by default */
 static int debug;	 /* insmod parameter */
 module_param(debug, int, S_IRUGO | S_IWUSR);
 module_param(loudness, int, S_IRUGO);
-MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");
 module_param(maxvol, int, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");
 
 
 
-- 
1.7.1.1