diff mbox

Missing 'select VIDEOBUF2_DMA_CONTIG'

Message ID 201107021116.44556.hverkuil@xs4all.nl (mailing list archive)
State Accepted
Headers show

Commit Message

Hans Verkuil July 2, 2011, 9:16 a.m. UTC
Hi Jon,

I get this error when compiling the latest for_v3.1 media_tree:

Kernel: arch/x86/boot/bzImage is ready  (#400)
ERROR: "vb2_dma_contig_init_ctx" [drivers/media/video/marvell-ccic/cafe_ccic.ko] undefined!
ERROR: "vb2_dma_contig_cleanup_ctx" [drivers/media/video/marvell-ccic/cafe_ccic.ko] undefined!
ERROR: "vb2_dma_contig_memops" [drivers/media/video/marvell-ccic/cafe_ccic.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

I think this is missing:


Can you confirm this?

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jonathan Corbet July 2, 2011, 1:51 p.m. UTC | #1
On Sat, 2 Jul 2011 11:16:44 +0200
Hans Verkuil <hverkuil@xs4all.nl> wrote:

> I think this is missing:
> 
> diff --git a/drivers/media/video/marvell-ccic/Kconfig b/drivers/media/video/marvell-ccic/Kconfig
> index 22314a0..68ff5d6 100644
> --- a/drivers/media/video/marvell-ccic/Kconfig
> +++ b/drivers/media/video/marvell-ccic/Kconfig
> @@ -3,6 +3,7 @@ config VIDEO_CAFE_CCIC
>  	depends on PCI && I2C && VIDEO_V4L2
>  	select VIDEO_OV7670
>  	select VIDEOBUF2_VMALLOC
> +	select VIDEOBUF2_DMA_CONTIG
>  	---help---
>  	  This is a video4linux2 driver for the Marvell 88ALP01 integrated
>  	  CMOS camera controller.  This is the controller found on first-
> 
> Can you confirm this?

Yes - the follow-on series I posted the other day fixes this.

Sorry for the trouble,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/video/marvell-ccic/Kconfig b/drivers/media/video/marvell-ccic/Kconfig
index 22314a0..68ff5d6 100644
--- a/drivers/media/video/marvell-ccic/Kconfig
+++ b/drivers/media/video/marvell-ccic/Kconfig
@@ -3,6 +3,7 @@  config VIDEO_CAFE_CCIC
 	depends on PCI && I2C && VIDEO_V4L2
 	select VIDEO_OV7670
 	select VIDEOBUF2_VMALLOC
+	select VIDEOBUF2_DMA_CONTIG
 	---help---
 	  This is a video4linux2 driver for the Marvell 88ALP01 integrated
 	  CMOS camera controller.  This is the controller found on first-