diff mbox

[-mmotm] media: video/adp1653.c needs module.h

Message ID 20110803101226.0d17b23e.rdunlap@xenotime.net (mailing list archive)
State New, archived
Headers show

Commit Message

Randy Dunlap Aug. 3, 2011, 5:12 p.m. UTC 
From: Randy Dunlap <rdunlap@xenotime.net>

adp1653.c uses interfaces that are provided by <linux/module.h>
and needs to include that header file to fix build errors.

drivers/media/video/adp1653.c:453: warning: data definition has no type or storage class
drivers/media/video/adp1653.c:453: warning: parameter names (without types) in function declaration
drivers/media/video/adp1653.c:474: error: 'THIS_MODULE' undeclared (first use in this function)
and more.

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/media/video/adp1653.c |    1 +
 1 file changed, 1 insertion(+)

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Stephen Rothwell Aug. 4, 2011, 12:23 a.m. UTC | #1 
Hi Randy,

On Wed, 3 Aug 2011 10:12:26 -0700 Randy Dunlap <rdunlap@xenotime.net> wrote:
>
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> adp1653.c uses interfaces that are provided by <linux/module.h>
> and needs to include that header file to fix build errors.
> 
> drivers/media/video/adp1653.c:453: warning: data definition has no type or storage class
> drivers/media/video/adp1653.c:453: warning: parameter names (without types) in function declaration
> drivers/media/video/adp1653.c:474: error: 'THIS_MODULE' undeclared (first use in this function)
> and more.
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>

That is a bug that is now in Linus' tree and this fix is pending in the
moduleh tree in linux-next.  So this patch should go to Linus.
diff mbox

Patch

--- mmotm-2011-0802-1619.orig/drivers/media/video/adp1653.c
+++ mmotm-2011-0802-1619/drivers/media/video/adp1653.c
@@ -32,6 +32,7 @@ 
 
 #include <linux/delay.h>
 #include <linux/i2c.h>
+#include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/version.h>
 #include <media/adp1653.h>