From patchwork Sat Aug 6 08:01:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 1041092 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p7681v2x008339 for ; Sat, 6 Aug 2011 08:01:57 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113Ab1HFIBw (ORCPT ); Sat, 6 Aug 2011 04:01:52 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:51330 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892Ab1HFIBv (ORCPT ); Sat, 6 Aug 2011 04:01:51 -0400 Received: by fxh19 with SMTP id 19so3548384fxh.19 for ; Sat, 06 Aug 2011 01:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=0N9UBwjou04knYcASdKov+WyLl4nqdQid/VaIsXIpss=; b=gP2VNIQ0SqmzCjawWl0aWVygT1GKQuMcCETZfk7BK6tcYSy8oERK7sTagLsaU5rcRq CQzlA8vkdMnohWdX0Iv8pxX37R69mFtefBSS+MJqgNwrZF19gVopMZs4A80Pr2vuenb3 48cn4cYg24txCqwFtJmbIVSikYBSxX9lWpxts= Received: by 10.223.2.129 with SMTP id 1mr1094405faj.60.1312617710294; Sat, 06 Aug 2011 01:01:50 -0700 (PDT) Received: from mwanda ([212.49.88.34]) by mx.google.com with ESMTPS id q15sm2516600fah.8.2011.08.06.01.01.44 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 06 Aug 2011 01:01:49 -0700 (PDT) Date: Sat, 6 Aug 2011 01:01:51 -0700 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Patrick Boettcher , Olivier Grenie , "open list:MEDIA INPUT INFRA..." , kernel-janitors@vger.kernel.org Subject: [patch] [media] dib9000: return error code on failure Message-ID: <20110806080151.GB28348@mwanda> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sat, 06 Aug 2011 08:01:58 +0000 (UTC) The ret = -EIO needs to be before the goto. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/dvb/frontends/dib9000.c b/drivers/media/dvb/frontends/dib9000.c index a085588..01e6b0c 100644 --- a/drivers/media/dvb/frontends/dib9000.c +++ b/drivers/media/dvb/frontends/dib9000.c @@ -1167,8 +1167,8 @@ static int dib9000_fw_get_channel(struct dvb_frontend *fe, struct dvb_frontend_p DibAcquireLock(&state->platform.risc.mem_mbx_lock); if (dib9000_fw_memmbx_sync(state, FE_SYNC_CHANNEL) < 0) { - goto error; ret = -EIO; + goto error; } dib9000_risc_mem_read(state, FE_MM_R_CHANNEL_UNION,