From patchwork Sat Aug 27 10:35:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Mickler X-Patchwork-Id: 1103662 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7RAaFcx025069 for ; Sat, 27 Aug 2011 10:36:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751355Ab1H0KgN (ORCPT ); Sat, 27 Aug 2011 06:36:13 -0400 Received: from ist.d-labs.de ([213.239.218.44]:40645 "EHLO mx01.d-labs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071Ab1H0KgM (ORCPT ); Sat, 27 Aug 2011 06:36:12 -0400 Received: from schatten.dmk.lab (f053223036.adsl.alicedsl.de [78.53.223.36]) by mx01.d-labs.de (Postfix) with ESMTPSA id B271F7F828; Sat, 27 Aug 2011 12:36:07 +0200 (CEST) Date: Sat, 27 Aug 2011 12:35:45 +0200 From: Florian Mickler To: Markus Stephan Cc: Jiri Slaby , pboettcher@kernellabs.com, linux-media@vger.kernel.org, mchehab@infradead.org Subject: Re: vp702x_fe_set_frontend+0x156/0x1a0 [dvb_usb_vp702x] Message-ID: <20110827123545.4bcf0943@schatten.dmk.lab> In-Reply-To: <4E580D7F.6070805@freenet.de> References: <4E580D7F.6070805@freenet.de> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.4; x86_64-pc-linux-gnu) Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Sat, 27 Aug 2011 10:36:15 +0000 (UTC) On Fri, 26 Aug 2011 23:17:51 +0200 Markus Stephan wrote: > Hi Florian, > > Jiri made an other test kernel for me with your final + debug patch applied. > > The box works fine and the message: > vp702x: usb in operation failed. (-110) > > seams to be triggered by: > vp702x_fe_set_frontend+0x156/0x1a0 [dvb_usb_vp702x] > > Full dmesg is attached. > > Thank you, > Markus Stephan Hi! Here is a patch to check if that failing op is even necessary. But even if it works I don't feel comfortable of suggesting this to be applied, since I don't have any overview about the hardware supported by this driver. Maybe Patrick has any opinion on this, he wrote this driver after all :) Regards, Flo >8------->8---------------->8--------->8---------------->8----------- commit fdcb46dd3627683fc82d14488af10d3072e923f5 Author: Florian Mickler Date: Sat Aug 27 12:01:34 2011 +0200 Let's check if that failing in-op is even necessary. Even if this turns out to be unnecessary, the right course of action is probably to still leave it there and demote the error message to debug information. --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/dvb/dvb-usb/vp702x-fe.c b/drivers/media/dvb/dvb-usb/vp702x-fe.c index ad16455..cb6c230 100644 --- a/drivers/media/dvb/dvb-usb/vp702x-fe.c +++ b/drivers/media/dvb/dvb-usb/vp702x-fe.c @@ -198,7 +198,7 @@ static int vp702x_fe_set_frontend(struct dvb_frontend* fe, st->status_check_interval = 250; st->next_status_check = jiffies; - vp702x_usb_inout_op(st->d, cmd, 8, cmd, 10, 100); + vp702x_usb_out_op(st->d, REQUEST_OUT, 0, 0, cmd, 10); if (cmd[2] == 0 && cmd[3] == 0) deb_fe("tuning failed.\n");