diff mbox

[RESEND] ov9640: fix missing break

Message ID 20120724155032.4082.19950.stgit@bluebook (mailing list archive)
State New, archived
Headers show

Commit Message

Alan Cox July 24, 2012, 3:50 p.m. UTC 
From: Alan Cox <alan@linux.intel.com>

Without this rev2 ends up behaving as rev3

Reported-by: dcb314@hotmail.com
Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44081
Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 drivers/media/video/ov9640.c |    1 +
 1 file changed, 1 insertion(+)


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Guennadi Liakhovetski July 29, 2012, 1:55 p.m. UTC | #1 
Hi Alan

On Tue, 24 Jul 2012, Alan Cox wrote:

> From: Alan Cox <alan@linux.intel.com>
> 
> Without this rev2 ends up behaving as rev3
> 
> Reported-by: dcb314@hotmail.com
> Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44081
> Signed-off-by: Alan Cox <alan@linux.intel.com>

Thanks, I'll push this for 3.6, and will ask Mauro to push this to stable 
too.

Thanks
Guennadi

> ---
> 
>  drivers/media/video/ov9640.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/video/ov9640.c b/drivers/media/video/ov9640.c
> index 23412de..9ed4ba4 100644
> --- a/drivers/media/video/ov9640.c
> +++ b/drivers/media/video/ov9640.c
> @@ -605,6 +605,7 @@ static int ov9640_video_probe(struct i2c_client *client)
>  		devname		= "ov9640";
>  		priv->model	= V4L2_IDENT_OV9640;
>  		priv->revision	= 2;
> +		break;
>  	case OV9640_V3:
>  		devname		= "ov9640";
>  		priv->model	= V4L2_IDENT_OV9640;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/video/ov9640.c b/drivers/media/video/ov9640.c
index 23412de..9ed4ba4 100644
--- a/drivers/media/video/ov9640.c
+++ b/drivers/media/video/ov9640.c
@@ -605,6 +605,7 @@  static int ov9640_video_probe(struct i2c_client *client)
 		devname		= "ov9640";
 		priv->model	= V4L2_IDENT_OV9640;
 		priv->revision	= 2;
+		break;
 	case OV9640_V3:
 		devname		= "ov9640";
 		priv->model	= V4L2_IDENT_OV9640;