From patchwork Sun Oct 7 13:03:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 1561111 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 884A1DFF71 for ; Sun, 7 Oct 2012 13:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751096Ab2JGNDI (ORCPT ); Sun, 7 Oct 2012 09:03:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52853 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794Ab2JGNDG (ORCPT ); Sun, 7 Oct 2012 09:03:06 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q97D34oc031347 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 7 Oct 2012 09:03:04 -0400 Received: from localhost.localdomain (vpn1-7-211.gru2.redhat.com [10.97.7.211]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q97D32pD029469; Sun, 7 Oct 2012 09:03:03 -0400 Date: Sun, 7 Oct 2012 10:03:01 -0300 From: Mauro Carvalho Chehab To: Wolfgang Bail Cc: linux-media@vger.kernel.org Subject: [PATCH] rc-msi-digivox-ii: Add full scan keycodes - Was: Re: v4l Message-ID: <20121007100301.3870ef32@redhat.com> In-Reply-To: <201209300549.26996.wolfgang.bail@t-online.de> References: <201209300549.26996.wolfgang.bail@t-online.de> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Sun, 30 Sep 2012 05:49:26 +0200 Wolfgang Bail escreveu: > Hello, > > the ir-rc from my msi DigiVox mini II Version 3 (af9015) will not work since > kernel 3.2.x (kubuntu 12.04), same with s2-liplianin or v4l. > > sudo ir-keytable -t shows: > > Testing events. Please, press CTRL-C to abort. > 1348890734.303273: event MSC: scancode = 317 > 1348890734.303280: event key down: KEY_POWER (0x0074) > 1348890734.303282: event sync > 1348890734.553961: event key up: KEY_POWER (0x0074) > 1348890734.553963: event sync > 1348890741.303451: event MSC: scancode = 30d > 1348890741.303457: event key down: KEY_DOWN (0x006c) > 1348890741.303459: event sync > ^[[B1348890741.553956: event key up: KEY_DOWN (0x006c) > > So I changed in rc-msi-digivox-ii.c { 0x0002, KEY_2 }, to { 0x0302, KEY_2 }, > and so on. And now it works well. > > I hope, my mini patch is standard, the first I made. Well, you should have using a subject like: [PATCH] rc-msi-digivox-ii: Add full scan keycodes And your signed-off-by. There are some pages at linuxtv.org wiki that points how to write a patch. Yet, as this is a really trivial one, I'll accept it without your Signed-off-by. > I don't know, whether > there are different variants of remote controls. But I don't believe it, > because it was ok with kernel 2.6.x. No, this seems just yet-another-regression caused by some patch that changed the code that gets IR scancode to report the 16-bit keycode, instead of just the last 8 bits. Thanks for it. > > @Mauro, thank you for the reply. > Regards, Mauro - FYI, this is how I applied it. From: Wolfgang Bail Date: Sat, 29 Sep 2012 23:49:26 -0300 Subject: [PATCH] [media] rc-msi-digivox-ii: Add full scan keycodes The ir-rc from my MSI DigiVox mini II Version 3 (af9015) will not work since kernel 3.2.x. sudo ir-keytable -t shows: 1348890734.303273: event MSC: scancode = 317 1348890734.303280: event key down: KEY_POWER (0x0074) 1348890734.303282: event sync 1348890734.553961: event key up: KEY_POWER (0x0074) 1348890734.553963: event sync 1348890741.303451: event MSC: scancode = 30d 1348890741.303457: event key down: KEY_DOWN (0x006c) 1348890741.303459: event sync 1348890741.553956: event key up: KEY_DOWN (0x006c) So I changed in rc-msi-digivox-ii.c { 0x0002, KEY_2 }, to { 0x0302, KEY_2 }, and so on. And now it works well. Signed-off-by: Mauro Carvalho Chehab Acked-by: Antti Palosaari --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/rc/keymaps/rc-msi-digivox-ii.c b/drivers/media/rc/keymaps/rc-msi-digivox-ii.c index c64e9e3..2fa71d0 100644 --- a/drivers/media/rc/keymaps/rc-msi-digivox-ii.c +++ b/drivers/media/rc/keymaps/rc-msi-digivox-ii.c @@ -22,24 +22,24 @@ #include static struct rc_map_table msi_digivox_ii[] = { - { 0x0002, KEY_2 }, - { 0x0003, KEY_UP }, /* up */ - { 0x0004, KEY_3 }, - { 0x0005, KEY_CHANNELDOWN }, - { 0x0008, KEY_5 }, - { 0x0009, KEY_0 }, - { 0x000b, KEY_8 }, - { 0x000d, KEY_DOWN }, /* down */ - { 0x0010, KEY_9 }, - { 0x0011, KEY_7 }, - { 0x0014, KEY_VOLUMEUP }, - { 0x0015, KEY_CHANNELUP }, - { 0x0016, KEY_OK }, - { 0x0017, KEY_POWER2 }, - { 0x001a, KEY_1 }, - { 0x001c, KEY_4 }, - { 0x001d, KEY_6 }, - { 0x001f, KEY_VOLUMEDOWN }, + { 0x0302, KEY_2 }, + { 0x0303, KEY_UP }, /* up */ + { 0x0304, KEY_3 }, + { 0x0305, KEY_CHANNELDOWN }, + { 0x0308, KEY_5 }, + { 0x0309, KEY_0 }, + { 0x030b, KEY_8 }, + { 0x030d, KEY_DOWN }, /* down */ + { 0x0310, KEY_9 }, + { 0x0311, KEY_7 }, + { 0x0314, KEY_VOLUMEUP }, + { 0x0315, KEY_CHANNELUP }, + { 0x0316, KEY_OK }, + { 0x0317, KEY_POWER2 }, + { 0x031a, KEY_1 }, + { 0x031c, KEY_4 }, + { 0x031d, KEY_6 }, + { 0x031f, KEY_VOLUMEDOWN }, }; static struct rc_map_list msi_digivox_ii_map = {