| Message ID | 20121121152809.51c780a6@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Em Wed, 21 Nov 2012 15:28:09 -0200 Mauro Carvalho Chehab <mchehab@redhat.com> escreveu: > Hi Andy, > > I'm understanding that you'll be reviewing this patch. So, I'm marking it as > under_review at patchwork. -ENOANSWER. Let me apply it, in order to fix the warning. > > Thanks, > Mauro > > Forwarded message: > > Date: Wed, 24 Oct 2012 10:14:16 -0200 > From: Fabio Estevam <festevam@gmail.com> > To: awalls@md.metrocast.net > Cc: mchehab@infradead.org, linux-media@vger.kernel.org, tj@kernel.org, Fabio Estevam <fabio.estevam@freescale.com> > Subject: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()' > > > From: Fabio Estevam <fabio.estevam@freescale.com> > > Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()), > flush_work() should be used instead of flush_work_sync(). > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/media/pci/ivtv/ivtv-driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/ivtv/ivtv-driver.c b/drivers/media/pci/ivtv/ivtv-driver.c > index 74e9a50..5d0a5df 100644 > --- a/drivers/media/pci/ivtv/ivtv-driver.c > +++ b/drivers/media/pci/ivtv/ivtv-driver.c > @@ -304,7 +304,7 @@ static void request_modules(struct ivtv *dev) > > static void flush_request_modules(struct ivtv *dev) > { > - flush_work_sync(&dev->request_module_wk); > + flush_work(&dev->request_module_wk); > } > #else > #define request_modules(dev)
On Thu, 2012-12-20 at 15:18 -0200, Mauro Carvalho Chehab wrote: > Em Wed, 21 Nov 2012 15:28:09 -0200 > Mauro Carvalho Chehab <mchehab@redhat.com> escreveu: > > > Hi Andy, > > > > I'm understanding that you'll be reviewing this patch. So, I'm marking it as > > under_review at patchwork. > > -ENOANSWER. Let me apply it, in order to fix the warning. Ooops. Sorry about that. Strictly speaking, I think the patch introduces a race condition that is extremely unlikely to be encountered, and it likely wouldn't have terrible consequences anyway. For the normal end-user, it will never be a problem. FWIW: Acked-by: Andy Walls <awalls@md.metrocast.net> Regards, Andy > > > > Thanks, > > Mauro > > > > Forwarded message: > > > > Date: Wed, 24 Oct 2012 10:14:16 -0200 > > From: Fabio Estevam <festevam@gmail.com> > > To: awalls@md.metrocast.net > > Cc: mchehab@infradead.org, linux-media@vger.kernel.org, tj@kernel.org, Fabio Estevam <fabio.estevam@freescale.com> > > Subject: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()' > > > > > > From: Fabio Estevam <fabio.estevam@freescale.com> > > > > Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()), > > flush_work() should be used instead of flush_work_sync(). > > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > --- > > drivers/media/pci/ivtv/ivtv-driver.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/pci/ivtv/ivtv-driver.c b/drivers/media/pci/ivtv/ivtv-driver.c > > index 74e9a50..5d0a5df 100644 > > --- a/drivers/media/pci/ivtv/ivtv-driver.c > > +++ b/drivers/media/pci/ivtv/ivtv-driver.c > > @@ -304,7 +304,7 @@ static void request_modules(struct ivtv *dev) > > > > static void flush_request_modules(struct ivtv *dev) > > { > > - flush_work_sync(&dev->request_module_wk); > > + flush_work(&dev->request_module_wk); > > } > > #else > > #define request_modules(dev) > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/pci/ivtv/ivtv-driver.c b/drivers/media/pci/ivtv/ivtv-driver.c index 74e9a50..5d0a5df 100644 --- a/drivers/media/pci/ivtv/ivtv-driver.c +++ b/drivers/media/pci/ivtv/ivtv-driver.c @@ -304,7 +304,7 @@ static void request_modules(struct ivtv *dev) static void flush_request_modules(struct ivtv *dev) { - flush_work_sync(&dev->request_module_wk); + flush_work(&dev->request_module_wk); } #else #define request_modules(dev)