From patchwork Sun Jan 6 17:26:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 1937891 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 941D23FC85 for ; Sun, 6 Jan 2013 17:27:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756064Ab3AFR10 (ORCPT ); Sun, 6 Jan 2013 12:27:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58609 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753067Ab3AFR1Z (ORCPT ); Sun, 6 Jan 2013 12:27:25 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r06HRM7V018148 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 6 Jan 2013 12:27:22 -0500 Received: from localhost.localdomain (vpn1-6-252.gru2.redhat.com [10.97.6.252]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r06HRK9o029018; Sun, 6 Jan 2013 12:27:21 -0500 Date: Sun, 6 Jan 2013 15:26:50 -0200 From: Mauro Carvalho Chehab To: LMML , Nickolai Zeldovich Subject: Fw: [PATCH] drivers/media/usb/dvb-usb/dib0700_core.c: fix left shift Message-ID: <20130106152650.2a89b31d@redhat.com> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Not sure what happened, but this patch didn't arrive linux-media. Let me forward. Regards, Mauro Forwarded message: Date: Sat, 5 Jan 2013 14:13:05 -0500 From: Nickolai Zeldovich To: Mauro Carvalho Chehab Cc: Nickolai Zeldovich , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH] drivers/media/usb/dvb-usb/dib0700_core.c: fix left shift Fix bug introduced in 7757ddda6f4febbc52342d82440dd4f7a7d4f14f, where instead of bit-negating the bitmask, the bit position was bit-negated instead. Signed-off-by: Nickolai Zeldovich --- drivers/media/usb/dvb-usb/dib0700_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c index 19b5ed2..92e195a 100644 --- a/drivers/media/usb/dvb-usb/dib0700_core.c +++ b/drivers/media/usb/dvb-usb/dib0700_core.c @@ -587,7 +587,7 @@ int dib0700_streaming_ctrl(struct dvb_usb_adapter *adap, int onoff) if (onoff) st->channel_state |= 1 << (adap->id); else - st->channel_state |= 1 << ~(adap->id); + st->channel_state &= ~(1 << (adap->id)); } else { if (onoff) st->channel_state |= 1 << (adap->fe_adap[0].stream.props.endpoint-2);