From patchwork Sat Dec 21 10:50:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 3393501 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6DF74C0D4A for ; Sat, 21 Dec 2013 10:51:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 81A7C20435 for ; Sat, 21 Dec 2013 10:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1234A2037D for ; Sat, 21 Dec 2013 10:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751766Ab3LUKuz (ORCPT ); Sat, 21 Dec 2013 05:50:55 -0500 Received: from mailout3.w2.samsung.com ([211.189.100.13]:40823 "EHLO usmailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291Ab3LUKuy (ORCPT ); Sat, 21 Dec 2013 05:50:54 -0500 Received: from uscpsbgm2.samsung.com (u115.gpu85.samsung.co.kr [203.254.195.115]) by usmailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MY500361KST4X30@usmailout3.samsung.com> for linux-media@vger.kernel.org; Sat, 21 Dec 2013 05:50:53 -0500 (EST) X-AuditID: cbfec373-b7f4a6d000005e0a-56-52b5728d0b57 Received: from ussync2.samsung.com ( [203.254.195.82]) by uscpsbgm2.samsung.com (USCPMTA) with SMTP id 0D.C8.24074.D8275B25; Sat, 21 Dec 2013 05:50:53 -0500 (EST) Received: from localhost.localdomain ([105.144.34.5]) by ussync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01 (7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MY500D6JKSPU430@ussync2.samsung.com>; Sat, 21 Dec 2013 05:50:53 -0500 (EST) Date: Sat, 21 Dec 2013 08:50:48 -0200 From: Mauro Carvalho Chehab To: kbuild test robot Cc: Antti Palosaari , linux-media@vger.kernel.org Subject: Re: [linuxtv-media:master 483/499] m88ds3103.c:undefined reference to `i2c_del_mux_adapter' Message-id: <20131221085048.40a00d81@samsung.com> In-reply-to: <52b4fca0.ygAJPoOJD83r3RML%fengguang.wu@intel.com> References: <52b4fca0.ygAJPoOJD83r3RML%fengguang.wu@intel.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDLMWRmVeSWpSXmKPExsVy+t/hIN3eoq1BBhd/Clh8b37PZvH++Xpm i54NW1kdmD0Of13I4rF4z0smj8+b5AKYo7hsUlJzMstSi/TtErgyfj2OKTgtXfFq1Rq2BsaX Yl2MnBwSAiYSx1e2s0PYYhIX7q1n62Lk4hASWMIo8fztKWYIp5tJ4sjlV4wgVSwCqhK/VnUx gdhsAkYSrxpbWEFsEQE9iRUL24BqODiYBewlNu4zAQkLC6RJHDm/jgXE5hUwlDj98ATYGE6g kj/7ZrKClAsJ2En8b5YEMSUEnCR2H5CCqBaU+DH5Hlgns4CWxOZtTawQtrzE5jVvmScwCsxC UjYLSdksJGULGJlXMYqWFicXFCel5xrpFSfmFpfmpesl5+duYoSEaPEOxhcbrA4xCnAwKvHw SkRuCRJiTSwrrsw9xCjBwawkwnsrbWuQEG9KYmVValF+fFFpTmrxIUYmDk6pBkZWt5wlc9ZP 6UuvzzI/vGrV/nD7qR++aLt8OGVygmvqx6fybIs7U9fet13+/jB3gahm1sU5CzT8M9/VTJXZ fnvhdy31qEXhwUoJ894dXWzlrl91vf60YUHpHffzofbtl/fsKi+atUbw7ayeU6Wb2k1VHLQr /N5+eHjkx+nyd5Ve6znYd4ncirqqxFKckWioxVxUnAgAUt6aMC8CAAA= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Em Sat, 21 Dec 2013 10:27:44 +0800 kbuild test robot escreveu: > tree: git://linuxtv.org/media_tree.git master > head: c57f87e62368c33ebda11a4993380c8e5a19a5c5 > commit: 44b9055b4b058d7b02bf0380158627f9be79b9e5 [483/499] [media] m88ds3103: use I2C mux for tuner I2C adapter > config: i386-randconfig-x0-12210941 (attached as .config) > > All error/warnings: > > warning: (VIDEO_EM28XX_DVB) selects DVB_M88DS3103 which has unmet direct dependencies (MEDIA_SUPPORT && DVB_CORE && I2C && I2C_MUX) > drivers/built-in.o: In function `m88ds3103_release': > >> m88ds3103.c:(.text+0x1ab1af): undefined reference to `i2c_del_mux_adapter' > drivers/built-in.o: In function `m88ds3103_attach': > >> (.text+0x1ab342): undefined reference to `i2c_add_mux_adapter' > > --- > 0-DAY kernel build testing backend Open Source Technology Center > http://lists.01.org/mailman/listinfo/kbuild Intel Corporation Not sure what's the best fix for this. I can see 3 alternatives: 1) make em28xx dependent on I2C_MUX. That sounds wrong, as the em28xx bridge doesn't have i2c muxes on it, and just one frontend has. Well, we may eventually convert all i2c gate stuff into i2c mux support, with makes sense, but it takes time and lots of effort. 2) we may make MEDIA_SUBDRV_AUTOSELECT dependent of I2C and I2C_MUX. That means that users will need to manually enable I2C_MUX on some distributions. Not sure about others, but, on Fedora, this option is disabled. So, we'll end by receiving a number of complains from users, until all distros that ship media start adding I2C_MUX. 3) if MEDIA_SUBDRV_AUTOSELECT is selected, it will select I2C and I2C_MUX. Of course, MEDIA_SUBDRV_AUTOSELECT will need to inherit all dependencies that I2C and I2C_MUX have (only HAS_IOMEM). The disadvantage is that, if new dependencies are added on I2C, they'll also need to be added here. As the hole idea of autoselect is to let the user not bother about whatever frontend/tuner is used by a driver, IMHO, (3) is the better solution. Patch for (3) is enclosed. diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index 8270388e2a0d..1d0758aeb8e4 100644 --- a/drivers/media/Kconfig +++ b/drivers/media/Kconfig @@ -172,6 +172,9 @@ comment "Media ancillary drivers (tuners, sensors, i2c, frontends)" config MEDIA_SUBDRV_AUTOSELECT bool "Autoselect ancillary drivers (tuners, sensors, i2c, frontends)" depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_CAMERA_SUPPORT + depends on HAS_IOMEM + select I2C + select I2C_MUX default y help By default, a media driver auto-selects all possible ancillary