From patchwork Mon Jun 30 06:45:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sami Laine X-Patchwork-Id: 4445861 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F1828BEEAA for ; Mon, 30 Jun 2014 06:46:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2C126202DD for ; Mon, 30 Jun 2014 06:46:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B8162024F for ; Mon, 30 Jun 2014 06:46:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754830AbaF3GpO (ORCPT ); Mon, 30 Jun 2014 02:45:14 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:34912 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754281AbaF3GpJ (ORCPT ); Mon, 30 Jun 2014 02:45:09 -0400 Received: by mail-la0-f51.google.com with SMTP id mc6so4555064lab.10 for ; Sun, 29 Jun 2014 23:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=x3QKRhcpFrtjJFlj1xNMzP4Zl7mwFvdKTdn2Qo1TgnA=; b=Y2J1aW0hrVLcuiEfaskFHlQR9i0EI8Xi5bOCz9zahGqkGBzIS4dIBcEBv5BXBmZpy3 OnJqPFnu6/eDm/qLEJH6LgNI/4c1TjjF/8eVUwWiOj1J6ehGr0HLP4b8p5Lt28fQCPDB HREhFFqFVqG8JpRvX3UpLDlaK4zkRlLXlzpUZgoSr1T3419M4vzB2keCz1GbW3+fb1O1 nP+S7JeLzy7fGM71WFmhcCTEoca2ezVHfjsx32sfkWW6Gk9laBGx/wzjEOELNBFyoekT fT4tQqieGYZBe3lICOnnS7DmvqfR1XxeAySktTxzCuK6sT/EEUZhYINhpdGo0ce2Hyrl /9gg== X-Received: by 10.152.115.134 with SMTP id jo6mr29333715lab.6.1404110707759; Sun, 29 Jun 2014 23:45:07 -0700 (PDT) Received: from outside ([91.223.107.37]) by mx.google.com with ESMTPSA id zx7sm22390685lbb.9.2014.06.29.23.45.06 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 29 Jun 2014 23:45:07 -0700 (PDT) Date: Mon, 30 Jun 2014 09:45:04 +0300 From: Sami Laine To: ismael.luceno@corp.bluecherry.net Cc: m.chehab@samsung.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, trivial@kernel.org Subject: [PATCH next-20140627] drivers/staging/media/solo6x10: sparse warning corrections Message-ID: <20140630064503.GA32377@outside> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sami Laine Sparse warning correction: CHECK drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c drivers/staging/media/solo6x10/solo6x10-jpeg.h:113:21: warning: symbol 'jpeg_dqt ' was not declared. Should it be static? The symbol jpeg_dqt is used just in solo6x10-v4l2-enc.c, so I think it makes sense to declare it static, which suppresses the sparse warning. Signed-off-by: Sami Laine --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/staging/media/solo6x10/solo6x10-jpeg.h b/drivers/staging/me index c5218ce..9e41185 100644 --- a/drivers/staging/media/solo6x10/solo6x10-jpeg.h +++ b/drivers/staging/media/solo6x10/solo6x10-jpeg.h @@ -110,7 +110,7 @@ static const unsigned char jpeg_header[] = { /* This is the byte marker for the start of the DQT */ #define DQT_START 17 #define DQT_LEN 138 -const unsigned char jpeg_dqt[4][DQT_LEN] = { +static const unsigned char jpeg_dqt[4][DQT_LEN] = { { 0xff, 0xdb, 0x00, 0x43, 0x00, 0x08, 0x06, 0x06, 0x07, 0x06, 0x05, 0x08, 0x07,