From patchwork Mon Dec 8 08:43:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 5454931 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D20199F30B for ; Mon, 8 Dec 2014 08:43:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1F13120158 for ; Mon, 8 Dec 2014 08:43:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DBDC2012E for ; Mon, 8 Dec 2014 08:43:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752780AbaLHInI (ORCPT ); Mon, 8 Dec 2014 03:43:08 -0500 Received: from www.linutronix.de ([62.245.132.108]:41669 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbaLHInH (ORCPT ); Mon, 8 Dec 2014 03:43:07 -0500 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1XxtuH-0002oY-MC; Mon, 08 Dec 2014 09:43:01 +0100 Date: Mon, 8 Dec 2014 09:43:01 +0100 From: Sebastian Andrzej Siewior To: Alan Stern Cc: linux-usb@vger.kernel.org, linux-media@vger.kernel.org, Greg Kroah-Hartman , Felipe Balbi , Sarah Sharp , Laurent Pinchart , Mauro Carvalho Chehab Subject: Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers() Message-ID: <20141208084301.GA10390@linutronix.de> References: <20141205200357.GA1586@linutronix.de> <20141205232327.GB4854@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141205232327.GB4854@linutronix.de> X-Key-Id: 97C4700B X-Key-Fingerprint: 09E2 D1F3 9A3A FF13 C3D3 961C 0688 1C1E 97C4 700B User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP * Sebastian Andrzej Siewior | 2014-12-06 00:23:27 [+0100]: >I had one patch doing that. Let me grab it out on Monday. okay, this is it. Laurent, any idea why this could not fly? I haven't seen anything odd so far. diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index 7c8322d4fc63..d656c7de25ef 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -1703,6 +1703,7 @@ static void uvc_unregister_video(struct uvc_device *dev) stream->vdev = NULL; uvc_debugfs_cleanup_stream(stream); + uvc_video_enable(stream, 0); } /* Decrement the stream count and call uvc_delete explicitly if there @@ -1950,10 +1951,6 @@ static void uvc_disconnect(struct usb_interface *intf) */ usb_set_intfdata(intf, NULL); - if (intf->cur_altsetting->desc.bInterfaceSubClass == - UVC_SC_VIDEOSTREAMING) - return; - dev->state |= UVC_DEV_DISCONNECTED; uvc_unregister_video(dev);