From patchwork Fri Dec 26 20:33:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 5543751 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 156C39F1CD for ; Fri, 26 Dec 2014 20:33:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 204C72011B for ; Fri, 26 Dec 2014 20:33:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 087F6201ED for ; Fri, 26 Dec 2014 20:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751134AbaLZUdp (ORCPT ); Fri, 26 Dec 2014 15:33:45 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:55894 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbaLZUdn (ORCPT ); Fri, 26 Dec 2014 15:33:43 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id E324781D79; Fri, 26 Dec 2014 21:33:40 +0100 (CET) Date: Fri, 26 Dec 2014 21:33:40 +0100 From: Pavel Machek To: Rob Herring Cc: Bryan Wu , Pali =?iso-8859-1?Q?Roh=E1r?= , Sebastian Reichel , Sebastian Reichel , kernel list , linux-arm-kernel , linux-omap , Tony Lindgren , khilman@kernel.org, Aaro Koskinen , freemangordon@abv.bg, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Benoit Cousson , sakari.ailus@iki.fi, Mauro Carvalho Chehab , "devicetree@vger.kernel.org" , "linux-media@vger.kernel.org" , Jacek Anaszewski Subject: Re: [PATCHv2] media: i2c/adp1653: devicetree support for adp1653 Message-ID: <20141226203340.GA1791@amd> References: <20141203214641.GA1390@amd> <20141224223434.GA20669@amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi! > > We are moving to device tree support on OMAP3, but that currently > > breaks ADP1653 driver. This adds device tree support, plus required > > documentation. > > > > Signed-off-by: Pavel Machek > > > > --- > > > > Changed -microsec to -us, as requested by devicetree people. > > > > Fixed checkpatch issues. > > > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > > index 2d88816..2c6c7c5 100644 > > --- a/Documentation/devicetree/bindings/leds/common.txt > > +++ b/Documentation/devicetree/bindings/leds/common.txt > > @@ -14,6 +14,15 @@ Optional properties for child nodes: > > "ide-disk" - LED indicates disk activity > > "timer" - LED flashes at a fixed, configurable rate > > > > +- max-microamp : maximum intensity in microamperes of the LED > > + (torch LED for flash devices) > > +- flash-max-microamp : maximum intensity in microamperes of the > > + flash LED; it is mandatory if the LED should > > + support the flash mode > > +- flash-timeout-microsec : timeout in microseconds after which the flash > > + LED is turned off > > Doesn't all this go in your flash led binding patch? No, I should not have included this part. > > +Example: > > + > > + adp1653: led-controller@30 { > > + compatible = "adi,adp1653"; > > + reg = <0x30>; > > + gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ > > + > > + flash { > > + flash-timeout-us = <500000>; > > + flash-max-microamp = <320000>; > > + max-microamp = <50000>; > > + }; > > + indicator { > > These are different LEDs or different modes? flash & indicator are different LEDs. One is white, one is red. Flash can be used as a flash and as a torch. > > + max-microamp = <17500>; > > This is a bit inconsistent. The binding says this is for flash LEDs > torch mode, but I see no reason why it can't be common. Can you update > the binding doc to be clear here. By inconsisnent, you mean you want patch below? > Also, aren't you missing label properties? label is optional, and as my driver does not yet use it, I forgot about it. Signed-off-by: Pavel Machek index 2c6c7c5..92d4dac 100644 --- a/Documentation/devicetree/bindings/leds/common.txt +++ b/Documentation/devicetree/bindings/leds/common.txt @@ -15,7 +15,6 @@ Optional properties for child nodes: "timer" - LED flashes at a fixed, configurable rate - max-microamp : maximum intensity in microamperes of the LED - (torch LED for flash devices) - flash-max-microamp : maximum intensity in microamperes of the flash LED; it is mandatory if the LED should support the flash mode