| Message ID | 20150415191218.GC32654@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Apr 15, 2015 at 8:12 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > This needs to be signed or there is a risk of hitting a forever loop. > > Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> Cheers, --Prabhakar Lad > diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c > index edebd11..d700a1d 100644 > --- a/drivers/media/i2c/ov2659.c > +++ b/drivers/media/i2c/ov2659.c > @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd, > struct v4l2_subdev_format *fmt) > { > struct i2c_client *client = v4l2_get_subdevdata(sd); > - unsigned int index = ARRAY_SIZE(ov2659_formats); > + int index = ARRAY_SIZE(ov2659_formats); > struct v4l2_mbus_framefmt *mf = &fmt->format; > const struct ov2659_framesize *size = NULL; > struct ov2659 *ov2659 = to_ov2659(sd); -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dan Carpenter <dan.carpenter@oracle.com> wrote on Wed [2015-Apr-15 22:12:18 +0300]: > This needs to be signed or there is a risk of hitting a forever loop. > > Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Acked-by: Benoit Parrot <bparrot@ti.com> > diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c > index edebd11..d700a1d 100644 > --- a/drivers/media/i2c/ov2659.c > +++ b/drivers/media/i2c/ov2659.c > @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd, > struct v4l2_subdev_format *fmt) > { > struct i2c_client *client = v4l2_get_subdevdata(sd); > - unsigned int index = ARRAY_SIZE(ov2659_formats); > + int index = ARRAY_SIZE(ov2659_formats); > struct v4l2_mbus_framefmt *mf = &fmt->format; > const struct ov2659_framesize *size = NULL; > struct ov2659 *ov2659 = to_ov2659(sd); -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c index edebd11..d700a1d 100644 --- a/drivers/media/i2c/ov2659.c +++ b/drivers/media/i2c/ov2659.c @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_format *fmt) { struct i2c_client *client = v4l2_get_subdevdata(sd); - unsigned int index = ARRAY_SIZE(ov2659_formats); + int index = ARRAY_SIZE(ov2659_formats); struct v4l2_mbus_framefmt *mf = &fmt->format; const struct ov2659_framesize *size = NULL; struct ov2659 *ov2659 = to_ov2659(sd);
This needs to be signed or there is a risk of hitting a forever loop. Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html