| Message ID | 20160311081301.GD31887@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Em Fri, 11 Mar 2016 11:13:01 +0300 Dan Carpenter <dan.carpenter@oracle.com> escreveu: > The code is checking for negative returns but it should be checking for > zero. > > Fixes: aab3125c43d8 ('[media] em28xx: add support for registering multiple i2c buses') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > Is -EBUSY correct? -EAGAIN? I guess -EAGAIN would be better. Regards, Mauro > > diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c > index a19b5c8..f80dd3a 100644 > --- a/drivers/media/usb/em28xx/em28xx-i2c.c > +++ b/drivers/media/usb/em28xx/em28xx-i2c.c > @@ -507,9 +507,8 @@ static int em28xx_i2c_xfer(struct i2c_adapter *i2c_adap, > if (dev->disconnected) > return -ENODEV; > > - rc = rt_mutex_trylock(&dev->i2c_bus_lock); > - if (rc < 0) > - return rc; > + if (!rt_mutex_trylock(&dev->i2c_bus_lock)) > + return -EBUSY; > > /* Switch I2C bus if needed */ > if (bus != dev->cur_i2c_bus && > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c index a19b5c8..f80dd3a 100644 --- a/drivers/media/usb/em28xx/em28xx-i2c.c +++ b/drivers/media/usb/em28xx/em28xx-i2c.c @@ -507,9 +507,8 @@ static int em28xx_i2c_xfer(struct i2c_adapter *i2c_adap, if (dev->disconnected) return -ENODEV; - rc = rt_mutex_trylock(&dev->i2c_bus_lock); - if (rc < 0) - return rc; + if (!rt_mutex_trylock(&dev->i2c_bus_lock)) + return -EBUSY; /* Switch I2C bus if needed */ if (bus != dev->cur_i2c_bus &&
The code is checking for negative returns but it should be checking for zero. Fixes: aab3125c43d8 ('[media] em28xx: add support for registering multiple i2c buses') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Is -EBUSY correct? -EAGAIN? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html