From patchwork Wed Nov 16 14:39:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9431763 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5DDC560476 for ; Wed, 16 Nov 2016 14:40:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 501D828713 for ; Wed, 16 Nov 2016 14:40:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4539128F1C; Wed, 16 Nov 2016 14:40:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBC2828713 for ; Wed, 16 Nov 2016 14:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933864AbcKPOkf (ORCPT ); Wed, 16 Nov 2016 09:40:35 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:62996 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932816AbcKPOkc (ORCPT ); Wed, 16 Nov 2016 09:40:32 -0500 Received: from wuerfel.lan ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPA (Nemesis) id 0M6AEI-1d0dsD0h90-00yAFU; Wed, 16 Nov 2016 15:40:23 +0100 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: Robert Jarzmik , Arnd Bergmann , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [media] pxa_camera: add V4L2 dependency Date: Wed, 16 Nov 2016 15:39:54 +0100 Message-Id: <20161116144016.2487252-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:xPe8z3bhtf365p9SgO/vIAXiZfi0oXDDp/yZ2zx4vb2jBNXRwMN VzPqbf+1Vla4TzP0hRXoSHAhK+UtFl7tfVq6kQqD5Jca1zd1Tu9me/BC47EnGFfiVqKWQ7P Q2NQuWbx/b+1z1XW5dVIjg3zJqk5UvljKmUDrUshRLtqAhcEM26GQoytdxM6QjCqF0dgxKi 4AMYGTLQtfI2o9f65QuVw== X-UI-Out-Filterresults: notjunk:1; V01:K0:FeeaoTyauRQ=:uowUPaQPUeLycs4xiiHEQ9 npEZG/cq+bunH7VCFEXPM4zLCJuAUE5TCOhp4c67uYICwYTNS4wph3kPMwnHeJq0cYY9zU2XH RYw16BpBdL49yHi084aDl9uSisYtR6mBeqcAww/IaV5vYJ0roJbEmL5HBf4dYmrx5xbdQcpaY taI/DduvrubcN9woyOI+W3O1uwVd4sU8bMUKJPIClTZ4qDgwVMio7MLG9j/a6VAoBl7e7tvH9 oQX3v3PozAwTYpQF1DiHivoGqbkDXyMqKH34XLixeKlW6iBSifTmwRC5nQxWosmJI7vtIWcgp 3tE3KDEzJhelTG+KwBHfSkShqFik5aUlUhG6Ni6U4F8OG1V8/GbaxOr5+mnzZSSvZdn5b9vFT 5U6jke4UceGm95gL2Tf8cRLl+laeXU7BqVTDqpyowaiBJ5IZEctBrW0SZpmX2jDDvdDOft7ZL fmbs0XXTv7lW35FH8fsHL7zmEOdYS361k5X/LTPZfRKqGzAREd7DmvYnd4Jzh+DVN4xpMNJKa /7wN3DrRF1mWMSUzvK+fjrSZWwPDpl6uAHPw1fg1Vjh3anw3PovFNNdKr0jFvFJYwhKj2IkMo 4DpchX2sidp/X7CF8Mn6u2g7EvJzyBgADO9V5K02xHTMZjkAYtXTQOQyYsF4kmp5A8eFv1cr3 Rx9lPLZVkP0gutbsdHekiV3V2Lwq8Iht7tTlCobHMOOGqr2T/WUOgSZzIkg4wlzPwtHQ= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Moving this driver out of soc_camera has resulted in a new randconfig failure: drivers/media/built-in.o: In function `pxa_camera_remove': pxa_camera.c:(.text+0x1854d): undefined reference to `v4l2_clk_unregister' pxa_camera.c:(.text+0x18555): undefined reference to `v4l2_device_unregister' drivers/media/built-in.o: In function `pxa_camera_sensor_unbind': pxa_camera.c:(.text+0x185dd): undefined reference to `video_unregister_device' As the driver now can be built for COMPILE_TEST as well, this means we can see the problem even on non-PXA platforms. Adding a dependency on VIDEO_V4L2 ensures this cannot happen and matches what the other drivers do. Fixes: 4bb738f228b3 ("[media] media: platform: pxa_camera: move pxa_camera out of soc_camera") Fixes: 5809ecdd6c3c ("[media] pxa_camera: allow building it if COMPILE_TEST is set") Signed-off-by: Arnd Bergmann --- drivers/media/platform/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index ce4a96fccc43..5ff803efdc03 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -93,7 +93,7 @@ config VIDEO_OMAP3_DEBUG config VIDEO_PXA27x tristate "PXA27x Quick Capture Interface driver" - depends on VIDEO_DEV && HAS_DMA + depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA depends on PXA27x || COMPILE_TEST select VIDEOBUF2_DMA_SG select SG_SPLIT