From patchwork Sun Nov 27 11:11:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Hasler X-Patchwork-Id: 9448751 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 103306071C for ; Sun, 27 Nov 2016 11:11:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0E3C4203C0 for ; Sun, 27 Nov 2016 11:11:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 02DD526224; Sun, 27 Nov 2016 11:11:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12AD4203C0 for ; Sun, 27 Nov 2016 11:11:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753904AbcK0LLz (ORCPT ); Sun, 27 Nov 2016 06:11:55 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35517 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753640AbcK0LLy (ORCPT ); Sun, 27 Nov 2016 06:11:54 -0500 Received: by mail-wm0-f67.google.com with SMTP id a20so14456817wme.2 for ; Sun, 27 Nov 2016 03:11:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :in-reply-to:user-agent; bh=16hWzmrF7bwum3N+Nki8fdrdKoE85LW5KAY5a92sgLQ=; b=py4KRLlto5v3IpekmpyTDN/FckgT35OSzD1CpB1ZecT2ILVBUHidhZs8gwfXEPoAu9 6Bhf909noE31wVx3QHRhnPvL0bxWqeqsQl9+PiNAVrhaCsg3HFAFsDu81NJ2U94Odr5T HKkNSFD3xWl2/4iJ2HF+fKeHTvLUj/oabl4frqEqHirRPk7q9TJ6W4GNejXBUNX7u6zZ kU+NuoBSDXuj/lnPJhbrhMmWvbCVZfYP/MeWAp317gNnC7wEma/Z8ceJglqoTcFAlkaF gcgO/V1kjpYkt+6jynYiaPjBE2V9AJN/ehP+R4sofrjpmnPq2oBnDcCM0Fr1FX+WYSA0 H6WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:in-reply-to:user-agent; bh=16hWzmrF7bwum3N+Nki8fdrdKoE85LW5KAY5a92sgLQ=; b=VgB84kc5o7Gcll/EmJQaj2W8g8nmhWKPunR7eB2gtms2kTakwmZYuxNhJJc8Pu3X3R TptmFpgzYS34PZGncuol55gqnYUkl29QNdCMfNQha3byMvNVhHjXQc6/sF+UYINNSWIX iBwF7c73Ly8vZciY1tWflgn1c0b5MuSZL5pEWBOGAg240q/mTpeID+hAyQTMTLTi36E/ viEGn9Crl0c+kRGmAQx+vC+tE/nsKbrGZerMJceMwiBCLpHdYFMmQLvSNCbIMtwlw3SC 09rSuzo65wcpT7tfhKHxIDn/+ve5wEbOGnZIuG9eQsPG/xT2g4VpD2NqSo6l3P7QMTTC 9B4A== X-Gm-Message-State: AKaTC00/ZoKUF7dmnRbQ1J2Bowom0IZL14zZDTRawzqBzEy1IwWaYMXgeqKhdLPWYbQNdw== X-Received: by 10.28.8.202 with SMTP id 193mr14093070wmi.101.1480245113023; Sun, 27 Nov 2016 03:11:53 -0800 (PST) Received: from arch-desktop ([2a02:908:678:0:728b:cdff:fe7f:6af7]) by smtp.gmail.com with ESMTPSA id xu5sm56570850wjc.49.2016.11.27.03.11.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 Nov 2016 03:11:52 -0800 (PST) Date: Sun, 27 Nov 2016 12:11:48 +0100 From: Marcel Hasler To: Ezequiel Garcia , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Subject: [PATCH v3 3/4] stk1160: Add module param for setting the record gain. Message-ID: <20161127111148.GA30483@arch-desktop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161127110732.GA5338@arch-desktop> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Allow setting a custom record gain for the internal AC97 codec (if available). This can be a value between 0 and 15, 8 is the default and should be suitable for most users. The Windows driver also sets this to 8 without any possibility for changing it. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/stk1160-ac97.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/stk1160/stk1160-ac97.c b/drivers/media/usb/stk1160/stk1160-ac97.c index 95648ac..60327af 100644 --- a/drivers/media/usb/stk1160/stk1160-ac97.c +++ b/drivers/media/usb/stk1160/stk1160-ac97.c @@ -28,6 +28,11 @@ #include "stk1160.h" #include "stk1160-reg.h" +static u8 gain = 8; + +module_param(gain, byte, 0444); +MODULE_PARM_DESC(gain, "Set capture gain level if AC97 codec is available (0-15, default: 8)"); + static void stk1160_write_ac97(struct stk1160 *dev, u16 reg, u16 value) { /* Set codec register address */ @@ -136,7 +141,10 @@ void stk1160_ac97_setup(struct stk1160 *dev) stk1160_write_ac97(dev, 0x16, 0x0808); /* Aux volume */ stk1160_write_ac97(dev, 0x1a, 0x0404); /* Record select */ stk1160_write_ac97(dev, 0x02, 0x0000); /* Master volume */ - stk1160_write_ac97(dev, 0x1c, 0x0808); /* Record gain */ + + /* Record gain */ + gain = (gain > 15) ? 15 : gain; + stk1160_write_ac97(dev, 0x1c, (gain<<8) | gain); #ifdef DEBUG stk1160_ac97_dump_regs(dev);