From patchwork Fri Feb 3 11:50:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 9553917 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 34016602B7 for ; Fri, 3 Feb 2017 11:50:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 254102849D for ; Fri, 3 Feb 2017 11:50:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1A28428478; Fri, 3 Feb 2017 11:50:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9058227FAD for ; Fri, 3 Feb 2017 11:50:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbdBCLut (ORCPT ); Fri, 3 Feb 2017 06:50:49 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33897 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbdBCLus (ORCPT ); Fri, 3 Feb 2017 06:50:48 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 5E19481727; Fri, 3 Feb 2017 12:50:46 +0100 (CET) Date: Fri, 3 Feb 2017 12:50:45 +0100 From: Pavel Machek To: Sakari Ailus Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, ivo.g.dimitrov.75@gmail.com, sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org Subject: Re: [PATCHv2] dt: bindings: Add support for CSI1 bus Message-ID: <20170203115045.GA1350@amd> References: <20161228183036.GA13139@amd> <20170111225335.GA21553@amd> <20170119214905.GD3205@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170119214905.GD3205@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi! > > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > > @@ -76,6 +76,11 @@ Optional endpoint properties > > mode horizontal and vertical synchronization signals are provided to the > > slave device (data source) by the master device (data sink). In the master > > mode the data source device is also the source of the synchronization signals. > > +- bus-type: data bus type. Possible values are: > > + 0 - MIPI CSI2 > > + 1 - parallel / Bt656 > > + 2 - MIPI CSI1 > > + 3 - CCP2 > > Actually, thinking about this again --- we only need to explictly specify > busses if we're dealing with either CCP2 or CSI-1. The vast majority of the > actual busses are and continue to be CSI-2 or either parallel or Bt.656. As > they can be implicitly detected, we would have an option to just drop values > 0 and 1 from above, i.e. only leave CSI-1 and CCP2. For now, specifying > CSI-2 or parallel / Bt.656 adds no value as the old DT binaries without > bus-type will need to be supported anyway. Hmm. "Just deleting the others" may be a bit confusing... but what about this? It explains what we can autodetect. Best regards, Pavel diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt index 08c4498..d54093b 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.txt +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt @@ -77,10 +77,10 @@ Optional endpoint properties slave device (data source) by the master device (data sink). In the master mode the data source device is also the source of the synchronization signals. - bus-type: data bus type. Possible values are: - 0 - MIPI CSI2 - 1 - parallel / Bt656 - 2 - MIPI CSI1 - 3 - CCP2 + 0 - autodetect based on other properties (MIPI CSI2, parallel, Bt656) + 1 - MIPI CSI1 + 2 - CCP2 + Autodetection is default, and bus-type property may be omitted in that case. - bus-width: number of data lines actively used, valid for the parallel busses. - data-shift: on the parallel data busses, if bus-width is used to specify the number of data lines, data-shift can be used to specify which data lines are