From patchwork Tue Feb 14 07:06:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sakari Ailus X-Patchwork-Id: 9571341 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 199C66045F for ; Tue, 14 Feb 2017 07:07:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B588208C2 for ; Tue, 14 Feb 2017 07:07:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 000A7228C9; Tue, 14 Feb 2017 07:07:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9CCC208C2 for ; Tue, 14 Feb 2017 07:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751023AbdBNHHJ (ORCPT ); Tue, 14 Feb 2017 02:07:09 -0500 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:38286 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750716AbdBNHHI (ORCPT ); Tue, 14 Feb 2017 02:07:08 -0500 Received: from valkosipuli.retiisi.org.uk (valkosipuli.retiisi.org.uk [IPv6:2001:1bc8:1a6:d3d5::80:2]) by hillosipuli.retiisi.org.uk (Postfix) with ESMTP id BC3B9600AA; Tue, 14 Feb 2017 09:06:59 +0200 (EET) Received: by valkosipuli.retiisi.org.uk (Postfix, from userid 1000) id 96ED12037F; Tue, 14 Feb 2017 09:06:59 +0200 (EET) Date: Tue, 14 Feb 2017 09:06:59 +0200 From: Sakari Ailus To: Benoit Parrot Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API Message-ID: <20170214070658.GJ16975@valkosipuli.retiisi.org.uk> References: <1486992496-21078-1-git-send-email-sakari.ailus@linux.intel.com> <1486992496-21078-6-git-send-email-sakari.ailus@linux.intel.com> <20170213165746.GB1103@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170213165746.GB1103@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Benoit, On Mon, Feb 13, 2017 at 10:57:47AM -0600, Benoit Parrot wrote: > Sakari Ailus wrote on Mon [2017-Feb-13 15:28:13 +0200]: ... > > @@ -421,6 +423,7 @@ config VIDEO_TI_VPE > > select VIDEO_TI_VPDMA > > select VIDEO_TI_SC > > select VIDEO_TI_CSC > > + select V4L2_FWNODE > > Sakari, > > TI_VPE does not use async registration, but as you already saw TI_CAL does. > So adding "select V4L2_FWNODE" should be moved to the VIDEO_TI_CAL section. > Once that's fixed you can add my acked-by for both the TI_CAL and AM437x_VPFE. Thanks for the review and for spotting this! I think I just used the name of the directory, and assumed that the matching Kconfig option is the right one. There don't seem to be other cases such as that one. diff: diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index cced276..2f7792c 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -129,6 +129,7 @@ config VIDEO_TI_CAL depends on SOC_DRA7XX || COMPILE_TEST depends on HAS_DMA select VIDEOBUF2_DMA_CONTIG + select V4L2_FWNODE default n ---help--- Support for the TI CAL (Camera Adaptation Layer) block @@ -423,7 +424,6 @@ config VIDEO_TI_VPE select VIDEO_TI_VPDMA select VIDEO_TI_SC select VIDEO_TI_CSC - select V4L2_FWNODE default n ---help--- Support for the TI VPE(Video Processing Engine) block