From patchwork Wed Feb 15 17:55:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 9574639 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4E46660586 for ; Wed, 15 Feb 2017 17:56:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 390F1284CC for ; Wed, 15 Feb 2017 17:56:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2D9C928502; Wed, 15 Feb 2017 17:56:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9636284DE for ; Wed, 15 Feb 2017 17:56:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752584AbdBOR4D (ORCPT ); Wed, 15 Feb 2017 12:56:03 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:34607 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752572AbdBORz7 (ORCPT ); Wed, 15 Feb 2017 12:55:59 -0500 Received: by mail-qt0-f194.google.com with SMTP id w20so21986300qtb.1; Wed, 15 Feb 2017 09:55:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8m+oDgsma2rguveW5ysTSoXcmjAOmfZDI6opXoOsO3k=; b=Dp0JWStLxZR9Q8jHQTrtCqNND3IaUoeUE4X1U+TpE/eiyVENSDmooCeksGvzOnwk7J vS8ACG2vwBB4UIb2nEo0cg5iJGqxJiNMi4VDvAC5JdkE8lHesCZRPZeeAXguBv6Cdfeq P/3NxzOlw0MoUp44AECxOyFuZFms1Ylz8g9TTu4nVbudMKTXLThthWXN6YjjMWMoj+su PMkv4xGxSu+gwTdkpmthucogP9GkGHzVh/vsMrgecXcQ/RMWDPY1+vjfTtXgGk8maLhI eigZ3g6/2Mc91tryqEWq6p0/QWo88FM5fqbmGCBT4LdEUTonEEXPQ6jdutbVRPRNpOyG 5r2Q== X-Gm-Message-State: AMke39ns4msbRUTtJRF4nF2ZOTTHA5c/rhddsK5kThssDYroez+MG7GWQkevIolKdLQkgg== X-Received: by 10.237.62.107 with SMTP id m40mr37704334qtf.196.1487181353001; Wed, 15 Feb 2017 09:55:53 -0800 (PST) Received: from localhost.localdomain ([187.64.235.185]) by smtp.gmail.com with ESMTPSA id f128sm2733329qkb.3.2017.02.15.09.55.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Feb 2017 09:55:52 -0800 (PST) From: Gustavo Padovan To: linux-media@vger.kernel.org Cc: Gustavo Padovan , Bluecherry Maintainers , Andrey Utkin , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 4/6] [media] tw5864: improve subscribe event handling Date: Wed, 15 Feb 2017 15:55:31 -0200 Message-Id: <20170215175533.6384-4-gustavo@padovan.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170215175533.6384-1-gustavo@padovan.org> References: <20170215175533.6384-1-gustavo@padovan.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan We already check for the V4L2_EVENT_CTRL inside v4l2_ctrl_subscribe_event() so just move this function to the default: branch of the switch and let it does the job for us. Signed-off-by: Gustavo Padovan Acked-by: Andrey Utkin --- drivers/media/pci/tw5864/tw5864-video.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/tw5864/tw5864-video.c b/drivers/media/pci/tw5864/tw5864-video.c index 9421216..6d5ed8e 100644 --- a/drivers/media/pci/tw5864/tw5864-video.c +++ b/drivers/media/pci/tw5864/tw5864-video.c @@ -664,15 +664,14 @@ static int tw5864_subscribe_event(struct v4l2_fh *fh, const struct v4l2_event_subscription *sub) { switch (sub->type) { - case V4L2_EVENT_CTRL: - return v4l2_ctrl_subscribe_event(fh, sub); case V4L2_EVENT_MOTION_DET: /* * Allow for up to 30 events (1 second for NTSC) to be stored. */ return v4l2_event_subscribe(fh, sub, 30, NULL); + default: + return v4l2_ctrl_subscribe_event(fh, sub); } - return -EINVAL; } static void tw5864_frame_interval_set(struct tw5864_input *input)