| Message ID | 20170301114545.GA19201@amd (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Pavel,
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.10 next-20170303]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pavel-Machek/omap3isp-Correctly-set-IO_OUT_SEL-and-VP_CLK_POL-for-CCP2-mode/20170303-164739
base: git://linuxtv.org/media_tree.git master
config: arm-omap2plus_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers/media/platform/omap3isp/ispccp2.c: In function 'ccp2_phyif_config':
>> drivers/media/platform/omap3isp/ispccp2.c:226:39: error: 'const struct isp_ccp2_cfg' has no member named 'vp_clk_pol'; did you mean 'vpclk_div'?
ISPCCP2_CTRL_VP_CLK_POL_MASK, buscfg->vp_clk_pol);
^
drivers/media/platform/omap3isp/ispccp2.c:61:8: note: in definition of macro 'BIT_SET'
| ((val) << (shift)); \
^~~
vim +226 drivers/media/platform/omap3isp/ispccp2.c
220 buscfg->phy_layer);
221 BIT_SET(val, ISPCCP2_CTRL_IO_OUT_SEL_SHIFT,
222 ISPCCP2_CTRL_IO_OUT_SEL_MASK, buscfg->ccp2_mode);
223 BIT_SET(val, ISPCCP2_CTRL_INV_SHIFT, ISPCCP2_CTRL_INV_MASK,
224 buscfg->strobe_clk_pol);
225 BIT_SET(val, ISPCCP2_CTRL_VP_CLK_POL_SHIFT,
> 226 ISPCCP2_CTRL_VP_CLK_POL_MASK, buscfg->vp_clk_pol);
227 isp_reg_writel(isp, val, OMAP3_ISP_IOMEM_CCP2, ISPCCP2_CTRL);
228
229 val = isp_reg_readl(isp, OMAP3_ISP_IOMEM_CCP2, ISPCCP2_CTRL);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi! > [auto build test ERROR on linuxtv-media/master] > [also build test ERROR on v4.10 next-20170303] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > Yes, the patch is against Sakari's ccp2 branch. It should work ok there. I don't think you can do much to fix the automated system.... Pavel
On Wed, Mar 01, 2017 at 12:45:46PM +0100, Pavel Machek wrote: > ISP CSI1 module needs all the bits correctly set to work. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > Signed-off-by: Pavel Machek <pavel@ucw.cz> > How are you sending the patches? I've applied this to the ccp2 branch.
On Sat 2017-03-04 17:15:34, Sakari Ailus wrote: > On Wed, Mar 01, 2017 at 12:45:46PM +0100, Pavel Machek wrote: > > ISP CSI1 module needs all the bits correctly set to work. > > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > How are you sending the patches? manually using mutt, for series I do something with git. Hmm. And script I was using for that disappeared :-(. > I've applied this to the ccp2 branch. Thanks, Pavel
On 03/03, Pavel Machek wrote: >Hi! > >> [auto build test ERROR on linuxtv-media/master] >> [also build test ERROR on v4.10 next-20170303] >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> > >Yes, the patch is against Sakari's ccp2 branch. It should work ok there. Could you tell us the url of Sakari's tree? thus we can add it to 0day's monitoring list. Thanks, Xiaolong > >I don't think you can do much to fix the automated system.... > > Pavel > >-- >(english) http://www.livejournal.com/~pavelmachek >(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html >_______________________________________________ >kbuild-all mailing list >kbuild-all@lists.01.org >https://lists.01.org/mailman/listinfo/kbuild-all
On Fri, Mar 03, 2017 at 10:48:38PM +0100, Pavel Machek wrote: >Hi! > >> [auto build test ERROR on linuxtv-media/master] >> [also build test ERROR on v4.10 next-20170303] >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> > >Yes, the patch is against Sakari's ccp2 branch. It should work ok there. > >I don't think you can do much to fix the automated system.... We could, if "git format-patch" can be setup to auto append lines parent-commit: X parent-patch-id: Y With that information, as long as the parent commit/patch is public -- either by "git push" or posting patch to mailing lists -- we'll have good chance to find and use it as the base for "git am". Currently "git format-patch" already has the option "--base=auto" to auto append the more accurate lines base-commit: P prerequisite-patch-id: X prerequisite-patch-id: Y prerequisite-patch-id: Z That's the best information git can offer. Unfortunately it cannot ALWAYS work without human aid. What's worse, when it cannot figure out the base-commit, the whole "git format-patch" command will abort like this $ git format-patch -1 fatal: base commit shouldn't be in revision list That fatal error makes it not a viable option to always turn on "--base=auto" in .gitconfig. Without a fully-automated solution, I don't think many people will bother or remember to manually specify base-commit before sending patches out. To effectively save the robot from "base commit" guessing works, what we can do is to 1) append "parent-commit"/"parent-patch-id" lines when git cannot figure out and append the "base-commit"/"prerequisite-patch-id" lines. So that the test robot always get the information to do its job. 2) advise kernel developers to run this once git config format.useAutoBase yes to configure "--base=auto" as the default behavior. Thanks, Fengguang
--- a/drivers/media/platform/omap3isp/ispccp2.c +++ b/drivers/media/platform/omap3isp/ispccp2.c @@ -213,14 +236,17 @@ static int ccp2_phyif_config(struct isp_ccp2_device *ccp2, struct isp_device *isp = to_isp_device(ccp2); u32 val; - /* CCP2B mode */ val = isp_reg_readl(isp, OMAP3_ISP_IOMEM_CCP2, ISPCCP2_CTRL) | - ISPCCP2_CTRL_IO_OUT_SEL | ISPCCP2_CTRL_MODE; + ISPCCP2_CTRL_MODE; /* Data/strobe physical layer */ BIT_SET(val, ISPCCP2_CTRL_PHY_SEL_SHIFT, ISPCCP2_CTRL_PHY_SEL_MASK, buscfg->phy_layer); + BIT_SET(val, ISPCCP2_CTRL_IO_OUT_SEL_SHIFT, + ISPCCP2_CTRL_IO_OUT_SEL_MASK, buscfg->ccp2_mode); BIT_SET(val, ISPCCP2_CTRL_INV_SHIFT, ISPCCP2_CTRL_INV_MASK, buscfg->strobe_clk_pol); + BIT_SET(val, ISPCCP2_CTRL_VP_CLK_POL_SHIFT, + ISPCCP2_CTRL_VP_CLK_POL_MASK, buscfg->vp_clk_pol); isp_reg_writel(isp, val, OMAP3_ISP_IOMEM_CCP2, ISPCCP2_CTRL); val = isp_reg_readl(isp, OMAP3_ISP_IOMEM_CCP2, ISPCCP2_CTRL); diff --git a/drivers/media/platform/omap3isp/ispreg.h b/drivers/media/platform/omap3isp/ispreg.h index b5ea8da..d084839 100644 --- a/drivers/media/platform/omap3isp/ispreg.h +++ b/drivers/media/platform/omap3isp/ispreg.h @@ -87,6 +87,8 @@ #define ISPCCP2_CTRL_PHY_SEL_MASK 0x1 #define ISPCCP2_CTRL_PHY_SEL_SHIFT 1 #define ISPCCP2_CTRL_IO_OUT_SEL (1 << 2) +#define ISPCCP2_CTRL_IO_OUT_SEL_MASK 0x1 +#define ISPCCP2_CTRL_IO_OUT_SEL_SHIFT 2 #define ISPCCP2_CTRL_MODE (1 << 4) #define ISPCCP2_CTRL_VP_CLK_FORCE_ON (1 << 9) #define ISPCCP2_CTRL_INV (1 << 10) @@ -94,6 +96,8 @@ #define ISPCCP2_CTRL_INV_SHIFT 10 #define ISPCCP2_CTRL_VP_ONLY_EN (1 << 11) #define ISPCCP2_CTRL_VP_CLK_POL (1 << 12) +#define ISPCCP2_CTRL_VP_CLK_POL_MASK 0x1 +#define ISPCCP2_CTRL_VP_CLK_POL_SHIFT 12 #define ISPCCP2_CTRL_VPCLK_DIV_SHIFT 15 #define ISPCCP2_CTRL_VPCLK_DIV_MASK 0x1ffff /* [31:15] */ #define ISPCCP2_CTRL_VP_OUT_CTRL_SHIFT 8 /* 3430 bits */