From patchwork Wed Mar 1 23:41:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9599273 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B1963600CB for ; Thu, 2 Mar 2017 00:11:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A31BD28559 for ; Thu, 2 Mar 2017 00:11:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 965972856E; Thu, 2 Mar 2017 00:11:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 51AF528559 for ; Thu, 2 Mar 2017 00:11:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753554AbdCBAKp (ORCPT ); Wed, 1 Mar 2017 19:10:45 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34588 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752865AbdCBAKo (ORCPT ); Wed, 1 Mar 2017 19:10:44 -0500 Received: by mail-pf0-f196.google.com with SMTP id x66so4873409pfb.1; Wed, 01 Mar 2017 16:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=g3E22pkKhNdCGtNgS3Yvxjq3aDrn8oWXbyK9ZrC89gg=; b=Ea0OtUfGRl189pLZhJ68e9LNokkuB/Ppd/5gB8XYGc5ssx/2DVBS6YnVAoxFF2+O1c 0hP3zpZj33Q3O9NQja54JbndPPNBaw5kd2+TxT/7NB2wmFmJLA+jHWn+LNRI/yFzqPWp tCBCr76nn5+WRy6UM+2EpH5CEZzHYqa9Uu3ef2qKAxuzhxS+AsalOyfZ+QhodBHwgC2m S7UnzsjtDm8NvDR9mI74mcXGq4OkiiB2GhDTxWadKE/VCO1P3hAyDB5L+xaxrYLSfnqY wu+7CrOnHoj2aVAE+yTwBdKNc2ina9nK9UO1Lb1lgvrQD5Vx6WkEAXlTtAXnFM7er1Wy JzKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=g3E22pkKhNdCGtNgS3Yvxjq3aDrn8oWXbyK9ZrC89gg=; b=eLGJInvvc/NrrfDAphtKrEOuY5RKeT27vwdaoscBzhUemZbEcT6HvCLbRpeCykP/FO 8wdevqMDmJFpdm8QAcN9hzjVuL7ronzALoCMwrG7L03vFnRynlyeaTJbpjtm+yXUI8H8 gOxml3LgSBSt+ite9xxP11qvEcPT+UM1vChdQoN5VSjVB0RzawrW4c4/ZjkmIjU8rQnV nPZwcs2KitSjwl4qMUVK+IbSC5vKSgYQlqHMal9QOkPTdERBLUCn3F6/1gpHGLYpWNJt aaq1Zwj2bsOk2L2z3Ix/oAx4QAhA8mZhaSzsA2+zRttyl+rNnAcQzVn1t5aPGympbbU8 2Qxw== X-Gm-Message-State: AMke39mbGn3YMKuI7dm5HOMUNVnnhjr0OIywFZ1rSRe/6V5EV4kRk+u8NQ6/SZso+jLmfg== X-Received: by 10.98.43.4 with SMTP id r4mr11843891pfr.96.1488411686314; Wed, 01 Mar 2017 15:41:26 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1311:f18a:a6c4:f29d:1ab0]) by smtp.gmail.com with ESMTPSA id a62sm12675013pgc.60.2017.03.01.15.41.25 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 01 Mar 2017 15:41:25 -0800 (PST) Date: Wed, 1 Mar 2017 15:41:23 -0800 From: Dmitry Torokhov To: Mauro Carvalho Chehab Cc: Pavel Machek , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [media] ad5820: remove incorrect __exit markups Message-ID: <20170301234123.GA12089@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov Acked-by: Pavel Machek --- drivers/media/i2c/ad5820.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c index a9026a91855e..3d2a3c6b67d8 100644 --- a/drivers/media/i2c/ad5820.c +++ b/drivers/media/i2c/ad5820.c @@ -336,7 +336,7 @@ static int ad5820_probe(struct i2c_client *client, return ret; } -static int __exit ad5820_remove(struct i2c_client *client) +static int ad5820_remove(struct i2c_client *client) { struct v4l2_subdev *subdev = i2c_get_clientdata(client); struct ad5820_device *coil = to_ad5820_device(subdev); @@ -362,7 +362,7 @@ static struct i2c_driver ad5820_i2c_driver = { .pm = &ad5820_pm, }, .probe = ad5820_probe, - .remove = __exit_p(ad5820_remove), + .remove = ad5820_remove, .id_table = ad5820_id_table, };