From patchwork Wed Mar 1 23:50:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9599347 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A287B604A8 for ; Thu, 2 Mar 2017 00:25:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 940C928565 for ; Thu, 2 Mar 2017 00:25:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8864028576; Thu, 2 Mar 2017 00:25:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1896B28565 for ; Thu, 2 Mar 2017 00:25:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbdCBAYk (ORCPT ); Wed, 1 Mar 2017 19:24:40 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33319 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753775AbdCBAWs (ORCPT ); Wed, 1 Mar 2017 19:22:48 -0500 Received: by mail-pg0-f66.google.com with SMTP id x17so7342488pgi.0; Wed, 01 Mar 2017 16:22:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=HSf9RU71fX32ddlF0FFhoYngRQUN5s1SqvtYc0nIwaA=; b=HLg+p7kOcP9DOYfsZuTXPycfzCRRBCczh7AO8+tZpwbWK9w9WwEFxMhjulMNz8iEXa ruimpSWSGlJ6lw8NH1D1oblw5SvX3dP2et3D9/nxXEumFFO3VBgR9OmW3548Babn421n 9gd0fYI/MVA46OgXyoStZRLADcArdO+iV1bUiZKD4z8WeH9oGg81no/7xIvaP+TPl+XK mK8JyqtQnzfSJrpWPwr9hFZ71splOB1idQM4ofTL+sGdU+6Rj23hW4s3AvznfileuJih XtRXzCwh5RdOWOhodJ4cOQghMKYbYI5SxYS/8YuNjbiXz3FJKQB8J00fOJFYBLGd1ETq acpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=HSf9RU71fX32ddlF0FFhoYngRQUN5s1SqvtYc0nIwaA=; b=lkByiQ3R3uliOGt198fIpmXWmO/mVAqDNglWmusstSTfgpOhENiPosMInPipSI2miq OkYkHLnOSpcUPSAqqjE0bZGDUQ4atzWPsde3fFFyJy1LjwujYD6kxEtwplVNSSu6u7Ha NnzpRwijWdzZZ01qRL7KdNIQpiuNAWUoWiV75vJWgbAZcoNQqKz1/WYASlxUjfgWt7xN 0wp9YAUEzapINDj571B/GL6wCYQHMVYOPKFgHslKQ5C1/BFmgWJ8QdwMJP4//RWHGaOF uO6+hXxQgVFx99ioG3XxRHzBXQdxv/kFzw67sd4qiQopzDbp/YvG4j91MKhNrEzclHiM PrjQ== X-Gm-Message-State: AMke39ku4L3NZeyhRgGqIlsDJAohk9uYJUIPJM9YKtem2ABL5hKYZf2+cYhQyDZSO8ccAg== X-Received: by 10.99.1.8 with SMTP id 8mr8731248pgb.53.1488412206627; Wed, 01 Mar 2017 15:50:06 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1311:f18a:a6c4:f29d:1ab0]) by smtp.gmail.com with ESMTPSA id e129sm12667804pfe.8.2017.03.01.15.50.05 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 01 Mar 2017 15:50:06 -0800 (PST) Date: Wed, 1 Mar 2017 15:50:03 -0800 From: Dmitry Torokhov To: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , Jean-Baptiste Abbadie , Claudiu Beznea , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] [media] Staging: media: radio-bcm2048: remove incorrect __exit markups Message-ID: <20170301235003.GA18340@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index 37bd439ee08b..1fba377f816b 100644 --- a/drivers/staging/media/bcm2048/radio-bcm2048.c +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c @@ -2634,7 +2634,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client *client, return err; } -static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client) +static int bcm2048_i2c_driver_remove(struct i2c_client *client) { struct bcm2048_device *bdev = i2c_get_clientdata(client); @@ -2673,7 +2673,7 @@ static struct i2c_driver bcm2048_i2c_driver = { .name = BCM2048_DRIVER_NAME, }, .probe = bcm2048_i2c_driver_probe, - .remove = __exit_p(bcm2048_i2c_driver_remove), + .remove = bcm2048_i2c_driver_remove, .id_table = bcm2048_id, };