| Message ID | 20170314185957.25253-14-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:54 Niklas Söderlund wrote: > With the driver stopping and starting the stream each time the driver is > stalled rvin_capture_off() can be folded in to the only caller. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/platform/rcar-vin/rcar-dma.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c > b/drivers/media/platform/rcar-vin/rcar-dma.c index > bd1ccb70ae2bc47e..c5fa176ac9d8cc4a 100644 > --- a/drivers/media/platform/rcar-vin/rcar-dma.c > +++ b/drivers/media/platform/rcar-vin/rcar-dma.c > @@ -396,12 +396,6 @@ static void rvin_capture_on(struct rvin_dev *vin) > rvin_write(vin, VNFC_S_FRAME, VNFC_REG); > } > > -static void rvin_capture_off(struct rvin_dev *vin) > -{ > - /* Set continuous & single transfer off */ > - rvin_write(vin, 0, VNFC_REG); > -} > - > static int rvin_capture_start(struct rvin_dev *vin) > { > struct rvin_buffer *buf, *node; > @@ -435,7 +429,8 @@ static int rvin_capture_start(struct rvin_dev *vin) > > static void rvin_capture_stop(struct rvin_dev *vin) > { > - rvin_capture_off(vin); > + /* Set continuous & single transfer off */ > + rvin_write(vin, 0, VNFC_REG); > > /* Disable module */ > rvin_write(vin, rvin_read(vin, VNMC_REG) & ~VNMC_ME, VNMC_REG);
diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c index bd1ccb70ae2bc47e..c5fa176ac9d8cc4a 100644 --- a/drivers/media/platform/rcar-vin/rcar-dma.c +++ b/drivers/media/platform/rcar-vin/rcar-dma.c @@ -396,12 +396,6 @@ static void rvin_capture_on(struct rvin_dev *vin) rvin_write(vin, VNFC_S_FRAME, VNFC_REG); } -static void rvin_capture_off(struct rvin_dev *vin) -{ - /* Set continuous & single transfer off */ - rvin_write(vin, 0, VNFC_REG); -} - static int rvin_capture_start(struct rvin_dev *vin) { struct rvin_buffer *buf, *node; @@ -435,7 +429,8 @@ static int rvin_capture_start(struct rvin_dev *vin) static void rvin_capture_stop(struct rvin_dev *vin) { - rvin_capture_off(vin); + /* Set continuous & single transfer off */ + rvin_write(vin, 0, VNFC_REG); /* Disable module */ rvin_write(vin, rvin_read(vin, VNMC_REG) & ~VNMC_ME, VNMC_REG);
With the driver stopping and starting the stream each time the driver is stalled rvin_capture_off() can be folded in to the only caller. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar-dma.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)