From patchwork Fri Mar 24 18:23:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scheller X-Patchwork-Id: 9643695 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8AADC602C9 for ; Fri, 24 Mar 2017 18:25:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CF2926907 for ; Fri, 24 Mar 2017 18:25:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 703F526E56; Fri, 24 Mar 2017 18:25:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1126826907 for ; Fri, 24 Mar 2017 18:25:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754381AbdCXSZw (ORCPT ); Fri, 24 Mar 2017 14:25:52 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34922 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935477AbdCXSZr (ORCPT ); Fri, 24 Mar 2017 14:25:47 -0400 Received: by mail-wm0-f65.google.com with SMTP id z133so2223216wmb.2 for ; Fri, 24 Mar 2017 11:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=6wujJTp1ToocVGaAA0tJbcugj+YSCTiC8waHZ5S5gI8=; b=gwoZmALEXq6CuSq1PRh5q8q19fvtH4MdcYxU5OPwCruRYoUfV8XEiuiSsVkMmP8xF7 Q8JBtPK3LXZ32WFXuLF74YU5E2q6w9a3jDyKkJPGXK4a8g8TkCMUhTOX91x/wl3mZdjZ 5S1LIWbZMnC+WFAgm/ux/FbWQ4Y64u8h9iI/vQkug/8fOlJqlGINnUbQtSNqc9g/E9p1 p385UGFuLu9FxMmVmFaDPNdFTUR7Ajg8stbFfZ9pwgK62zOs5y0KdEBvvKJeOwAgaHW1 DxTFErk7j1hsGFINBk/NPWhqCI6sb4cB0XkqmeFQEFDA3eNtp37LRYw+diRnk2xJUv2J EkTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=6wujJTp1ToocVGaAA0tJbcugj+YSCTiC8waHZ5S5gI8=; b=RCWA2Nb32IWtfrv+Nx93t2vHfD9M9IUGUU6DqeZnBnr0DCRuMBtoHtBUbVn3BxBxHF H8J4epVEhREe2I/n/PeFtSi4O5b7U57rC11xxiV1PgoYLnc2RJqU2FzQwdeeQQIBXUN2 eStFZ2sE1huHJOy7X0daLUAiZTiWF08Mbnp2nVxdFA9wLGklgis7FZZ3lAhNSskRYbkw mW0WOFKTNTp1lnZit/66a7qriSdUliJm+w8Xt1NXvvhnB2EvQmyjBdKv2L4bWf3BVuwA zFVFl5GrG6eVa7XR00HMVVS/4p7q+XlMQW6zP8ZBSxiklCgssTWOqZbibcwu7jvEHNGz uEEA== X-Gm-Message-State: AFeK/H34AuQeMSU82nBBUtPjzzk6500yjoK835MgmuW4WIwbPI7FxKNv0q7WW4fwG5OnAw== X-Received: by 10.28.146.12 with SMTP id u12mr4632351wmd.142.1490379939529; Fri, 24 Mar 2017 11:25:39 -0700 (PDT) Received: from dvbdev.wuest.de (ip-37-24-178-151.hsi14.unitymediagroup.de. [37.24.178.151]) by smtp.gmail.com with ESMTPSA id w12sm3830519wra.21.2017.03.24.11.25.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Mar 2017 11:25:39 -0700 (PDT) From: Daniel Scheller To: mchehab@kernel.org, linux-media@vger.kernel.org Subject: [PATCH v2 02/12] [media] dvb-frontends/stv0367: print CPAMP status only if stv_debug is enabled Date: Fri, 24 Mar 2017 19:23:58 +0100 Message-Id: <20170324182408.25996-3-d.scheller.oss@gmail.com> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20170324182408.25996-1-d.scheller.oss@gmail.com> References: <20170324182408.25996-1-d.scheller.oss@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Scheller The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed everytime tuning succeeds or fails, quite cluttering the normal kernel log. Use dprintk() instead of printk(KERN_ERR...) so that if the information is needed, it'll be printed when the stv_debug modparam is enabled. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c index fc80934..0064d9d 100644 --- a/drivers/media/dvb-frontends/stv0367.c +++ b/drivers/media/dvb-frontends/stv0367.c @@ -1262,9 +1262,9 @@ stv0367_ter_signal_type stv0367ter_check_cpamp(struct stv0367_state *state, dprintk("******last CPAMPvalue= %d at wd=%d\n", CPAMPvalue, wd); if (CPAMPvalue < CPAMPMin) { CPAMPStatus = FE_TER_NOCPAMP; - printk(KERN_ERR "CPAMP failed\n"); + dprintk("%s: CPAMP failed\n", __func__); } else { - printk(KERN_ERR "CPAMP OK !\n"); + dprintk("%s: CPAMP OK !\n", __func__); CPAMPStatus = FE_TER_CPAMPOK; }