From patchwork Wed Mar 29 16:43:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scheller X-Patchwork-Id: 9651969 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C91AB602C8 for ; Wed, 29 Mar 2017 16:43:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BBB232845F for ; Wed, 29 Mar 2017 16:43:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B091228497; Wed, 29 Mar 2017 16:43:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 216652845F for ; Wed, 29 Mar 2017 16:43:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753026AbdC2Qnd (ORCPT ); Wed, 29 Mar 2017 12:43:33 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:32842 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752869AbdC2QnT (ORCPT ); Wed, 29 Mar 2017 12:43:19 -0400 Received: by mail-wr0-f193.google.com with SMTP id u18so4575628wrc.0 for ; Wed, 29 Mar 2017 09:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6wujJTp1ToocVGaAA0tJbcugj+YSCTiC8waHZ5S5gI8=; b=j3Ful9JnbFpkjNrj0o57pyOpC1EfcaJV/NvPZ5UegzncujzEvvtXfFg//kv9YNWS94 so8Bp9Om/QHAGps87XPMqoGWmRe6l2njdpt0l0cwHXL2o8I5sIK0YZug8xrN2+GI6B7p xFTtQ6pjU4YGIcVeWeX9ogmXCA0nY85boKwILsTrgIBV8oBJVfBoRc+H/n0wXkkU4q/I dFV/msydqZIys+4z485sGpKVGsK4hXk2vC9DNC8WzLrbMrsN8UDxAO3gFPIrMCid0iHW OAEYXwa6udKaMB0vKhDhZgIgSI5oJqU3MFf6LZxVroASDixqgdrYGSrHiODMyg7GZTVl eREA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6wujJTp1ToocVGaAA0tJbcugj+YSCTiC8waHZ5S5gI8=; b=Nj1AlGDp6wTnfWRwwyWC+GPNHDwctoptY1mw4u5syWZrrmfzwX414HT3IWvHOnWuKW Y+SVRWgt/mUUnRpX2ufPZtNeQjzGBZhnopckyN0DX6FGzV6QStoFCJtT23Jxue9s5JnA XZb1VXrrOC3Wmb1ABqFqWsLgmH5ey3SjG1RaYWKfsqzHh5rTpH5S0WCZSN6NmOcwEHR3 eF1D0xScTxG3CGX3NdASC0dCQD8mzS7bNonfmDS4q48DHElmG/g+FFEqnp4jFEt25APy MHo9cRi1al+ynTnR1QyWx3N1NRcy/E+bmIPbx2rmziTXxDJ9Wf+u9evy1XWwpmUK1Bu6 qd9Q== X-Gm-Message-State: AFeK/H34bbC53Gdh5SzhfkR6ltRg86AonjaKJcOo61n/C05dgP+JyfsesCxKY0i8VhD+bw== X-Received: by 10.28.184.87 with SMTP id i84mr1599638wmf.129.1490805797546; Wed, 29 Mar 2017 09:43:17 -0700 (PDT) Received: from dvbdev.wuest.de (ip-37-24-178-151.hsi14.unitymediagroup.de. [37.24.178.151]) by smtp.gmail.com with ESMTPSA id x127sm8835277wmf.31.2017.03.29.09.43.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 29 Mar 2017 09:43:16 -0700 (PDT) From: Daniel Scheller To: linux-media@vger.kernel.org, mchehab@kernel.org Cc: liplianin@netup.ru, rjkm@metzlerbros.de, crope@iki.fi Subject: [PATCH v3 02/13] [media] dvb-frontends/stv0367: print CPAMP status only if stv_debug is enabled Date: Wed, 29 Mar 2017 18:43:02 +0200 Message-Id: <20170329164313.14636-3-d.scheller.oss@gmail.com> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20170329164313.14636-1-d.scheller.oss@gmail.com> References: <20170329164313.14636-1-d.scheller.oss@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Scheller The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed everytime tuning succeeds or fails, quite cluttering the normal kernel log. Use dprintk() instead of printk(KERN_ERR...) so that if the information is needed, it'll be printed when the stv_debug modparam is enabled. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c index fc80934..0064d9d 100644 --- a/drivers/media/dvb-frontends/stv0367.c +++ b/drivers/media/dvb-frontends/stv0367.c @@ -1262,9 +1262,9 @@ stv0367_ter_signal_type stv0367ter_check_cpamp(struct stv0367_state *state, dprintk("******last CPAMPvalue= %d at wd=%d\n", CPAMPvalue, wd); if (CPAMPvalue < CPAMPMin) { CPAMPStatus = FE_TER_NOCPAMP; - printk(KERN_ERR "CPAMP failed\n"); + dprintk("%s: CPAMP failed\n", __func__); } else { - printk(KERN_ERR "CPAMP OK !\n"); + dprintk("%s: CPAMP OK !\n", __func__); CPAMPStatus = FE_TER_CPAMPOK; }