From patchwork Wed May 3 20:24:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 9710359 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 47F1960351 for ; Wed, 3 May 2017 20:24:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B1D428306 for ; Wed, 3 May 2017 20:24:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F8DF283FD; Wed, 3 May 2017 20:24:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AFC4528306 for ; Wed, 3 May 2017 20:24:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757711AbdECUYa (ORCPT ); Wed, 3 May 2017 16:24:30 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36836 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754354AbdECUY3 (ORCPT ); Wed, 3 May 2017 16:24:29 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id B856B819F9; Wed, 3 May 2017 22:24:27 +0200 (CEST) Date: Wed, 3 May 2017 22:24:27 +0200 From: Pavel Machek To: Sakari Ailus Cc: Laurent Pinchart , mchehab@kernel.org, kernel list , ivo.g.dimitrov.75@gmail.com, sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org Subject: Re: [PATCHv2] omap3isp: add support for CSI1 bus Message-ID: <20170503202427.GA18616@amd> References: <10545906.Gxg3yScdu4@avalon> <20170215094228.GA8586@amd> <2414221.XNA4JCFMRx@avalon> <20170302090143.GB27818@amd> <20170302101603.GE27818@amd> <20170302112401.GF3220@valkosipuli.retiisi.org.uk> <20170302123848.GA28230@amd> <20170304130318.GU3220@valkosipuli.retiisi.org.uk> <20170503195039.GB12396@amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170503195039.GB12396@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi! > It seems they don't compile. Hmmm. Did I do something wrong? "struct > fwnode_endpoint" seems to be only used in v4l2-fwnode.h; that can't be right...? Next problem is missing dev_fwnode; fixed. Next problem is pavel@duo:/data/l/linux-n900$ git grep fwnode_graph_get_next_endpoint . drivers/media/i2c/smiapp/smiapp-core.c: ep = fwnode_graph_get_next_endpoint(fwnode, NULL); drivers/media/platform/omap3isp/isp.c: while ((fwnode = fwnode_graph_get_next_endpoint(dev_fwnode(dev), So sorry, I guess I should wait for version that compiles ;-). Pavel diff --git a/drivers/base/property.c b/drivers/base/property.c index c458c63..f52a260 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -182,11 +182,6 @@ static int pset_prop_read_string(struct property_set *pset, return 0; } -static inline struct fwnode_handle *dev_fwnode(struct device *dev) -{ - return IS_ENABLED(CONFIG_OF) && dev->of_node ? - &dev->of_node->fwnode : dev->fwnode; -} /** * device_property_present - check if a property of a device is present diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index 8bd28ce..9215e23 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h @@ -27,4 +27,10 @@ struct fwnode_handle { struct fwnode_handle *secondary; }; +static inline struct fwnode_handle *dev_fwnode(struct device *dev) +{ + return IS_ENABLED(CONFIG_OF) && dev->of_node ? + &dev->of_node->fwnode : dev->fwnode; +} + #endif diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h index d762a55..9e9cfbc 100644 --- a/include/media/v4l2-fwnode.h +++ b/include/media/v4l2-fwnode.h @@ -80,7 +80,7 @@ struct v4l2_fwnode_bus_mipi_csi1 { * @nr_of_link_frequencies: number of elements in link_frequenccies array */ struct v4l2_fwnode_endpoint { - struct fwnode_endpoint base; + /*struct fwnode_endpoint base; */ /* * Fields below this line will be zeroed by * v4l2_fwnode_parse_endpoint()