From patchwork Tue Jun 20 19:57:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scheller X-Patchwork-Id: 9800151 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8E659600F5 for ; Tue, 20 Jun 2017 19:57:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 84ECF281E1 for ; Tue, 20 Jun 2017 19:57:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 77D31283AF; Tue, 20 Jun 2017 19:57:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16192281E1 for ; Tue, 20 Jun 2017 19:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751985AbdFTT52 (ORCPT ); Tue, 20 Jun 2017 15:57:28 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36543 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbdFTT51 (ORCPT ); Tue, 20 Jun 2017 15:57:27 -0400 Received: by mail-wr0-f195.google.com with SMTP id 77so20148773wrb.3 for ; Tue, 20 Jun 2017 12:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=j/i4AW4+g09TobEdXt2t/dCC3OrJz+oV8DT0hCE1iRY=; b=epEHTqh1APsC4hI+d1gPYqlj9boviNNFR+XvDN1soFkpxH5PZuniP2sQD/43Axhcjc Ie8D+RLy9IUBIu7CQt5a9MtqRTCqnVH+maMj3Y5l7n45baHqaiBUQEWA5TfbLg9o8g4m b0ThFtt54+yQBYHkZvaH84tI+5zePMPyiiXcfM8F85MLpx5lxAwnCRQMf7oct8kdRMfK Pl//x2kwGeLm0PrUW0Mr8jMMZkB/k9WR0xbfO12jFtUZcESQQCoN++uMGQLWG6fJSvmM lDAgkTTV9ugY3Wk2DvNnOIrglyEolFog3WNzjNc5h0NWYJv4lHuDjpaYACfG0G5JKvaR rXkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=j/i4AW4+g09TobEdXt2t/dCC3OrJz+oV8DT0hCE1iRY=; b=NoqIXOa/RwURMldNKgAOMT3khikgaBTQ+NlzSm4a8HsbzA5jzmxgf0pIUSZrFhJ5Is Sr1496OoIUmIqDrw4HV9DHmX7n+HPi93C4XGRKX/67FKyxxAnk/uyac8HgrGwN7IqI6w WodqxXTY2L06T2SB8CmLQkfqxY5WKGr3DXGv1aLLzpSEHTymeanHy/c4kXmFt33aMjl1 jVqreEv7o81ugPTF9+jgQ4eKFHaffGKEKW2Ovw4cVlrQDb9cpn7ni8n5RTULdCTZJCkD bbHMrww/f3E0Q1vyMHZ5INanRnx9uSDR6m/1oleMOed+jTmVe+Vqw6aqfQgI7fQyX+G4 H2DA== X-Gm-Message-State: AKS2vOy8hRsf2ftwNrXETpEeeWJPhmv7ZJh79ZCrCPC7rCnvmSMmfofx Rx/3b254CJ6RYEE3 X-Received: by 10.28.184.195 with SMTP id i186mr4025738wmf.98.1497988645932; Tue, 20 Jun 2017 12:57:25 -0700 (PDT) Received: from dvbdev.wuest.de (ip-37-24-178-151.hsi14.unitymediagroup.de. [37.24.178.151]) by smtp.gmail.com with ESMTPSA id c27sm3997593wrb.44.2017.06.20.12.57.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Jun 2017 12:57:25 -0700 (PDT) From: Daniel Scheller To: linux-media@vger.kernel.org, mchehab@kernel.org, aospan@netup.ru, serjk@netup.ru Subject: [PATCH] [media] dvb-frontends/lnbh25: improve kernellog output Date: Tue, 20 Jun 2017 21:57:24 +0200 Message-Id: <20170620195724.8271-1-d.scheller.oss@gmail.com> X-Mailer: git-send-email 2.13.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Scheller Use dev_dbg() in conjunction with the %*ph format macro to print the vmon status debug, thus hiding continuous hexdumping from default log levels. Also, change the attach success log line from error to info severity. Signed-off-by: Daniel Scheller Acked-by: Abylay Ospan --- drivers/media/dvb-frontends/lnbh25.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/lnbh25.c b/drivers/media/dvb-frontends/lnbh25.c index ef3021e964be..cb486e879fdd 100644 --- a/drivers/media/dvb-frontends/lnbh25.c +++ b/drivers/media/dvb-frontends/lnbh25.c @@ -76,8 +76,8 @@ static int lnbh25_read_vmon(struct lnbh25_priv *priv) return ret; } } - print_hex_dump_bytes("lnbh25_read_vmon: ", - DUMP_PREFIX_OFFSET, status, sizeof(status)); + dev_dbg(&priv->i2c->dev, "%s(): %*ph\n", + __func__, (int) sizeof(status), status); if ((status[0] & (LNBH25_STATUS_OFL | LNBH25_STATUS_VMON)) != 0) { dev_err(&priv->i2c->dev, "%s(): voltage in failure state, status reg 0x%x\n", @@ -178,7 +178,7 @@ struct dvb_frontend *lnbh25_attach(struct dvb_frontend *fe, fe->ops.release_sec = lnbh25_release; fe->ops.set_voltage = lnbh25_set_voltage; - dev_err(&i2c->dev, "%s(): attached at I2C addr 0x%02x\n", + dev_info(&i2c->dev, "%s(): attached at I2C addr 0x%02x\n", __func__, priv->i2c_address); return fe; }