From patchwork Wed Jul 5 05:33:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 9825851 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 569EB60237 for ; Wed, 5 Jul 2017 05:34:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 483E522B1F for ; Wed, 5 Jul 2017 05:34:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3991F26CFF; Wed, 5 Jul 2017 05:34:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB7F322B1F for ; Wed, 5 Jul 2017 05:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbdGEFeC (ORCPT ); Wed, 5 Jul 2017 01:34:02 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:34401 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbdGEFeB (ORCPT ); Wed, 5 Jul 2017 01:34:01 -0400 Received: by mail-pf0-f171.google.com with SMTP id q85so10584260pfq.1 for ; Tue, 04 Jul 2017 22:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=owAZQ6A7+9rn/szNZm/+/d9LHnLdAAn8PSLgerl+1AI=; b=VvQE4mmx8C0JGpXXWg5kdlBn1nM3H/YZnWovPklMrkv1mnYW8ISvJcLlfeAZDGglE3 JYqN9GL2z/Rq/D4vf3KBGnCmdMtyH5/8ttO+j00nk/k0Dl7YqBkQwieAEos3R72iWvXt ioStm1ebrvelypEFqcOuQY3neZVrqUB1AjNWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=owAZQ6A7+9rn/szNZm/+/d9LHnLdAAn8PSLgerl+1AI=; b=UgB3VnMpXsNnoc18hNJ+H6mMsbsxU1CJzfx9WYfpjdD5MGz1Z7NgM21AmVsKYnsDE4 q+mO9vij90cqcnxS8Uqaiyh+WZ8oAIxPAxIFYaz6RwRd07r6fNNAGxrQ4IuLdtEw2bgB hVLiqzTJ6UJlCTEzaWosWcMFnuSXW5kvFnDvuHkDHQ/zhT3I/VusabXfrVEQ54+qCDvM NxRbnLmITkqThZnw5uFzBpHaB4dHsDolcpcUpHulgXjyefza/d+obfS44aI5LPz8+vFb jBeGQ5SkLlAjzR9PcsFEQSvhc9TiVL834eYITAnPrvusWT550bfpLKe+je/O2Skl0ydZ hgAg== X-Gm-Message-State: AIVw113Ew9ERAb04VkNcjtbGcZ1BI/KrtJWDDmEyL3nAyZDhpBONUkg2 1eJ81/gxoLnAjxIA X-Received: by 10.84.168.131 with SMTP id f3mr20292454plb.220.1499232840371; Tue, 04 Jul 2017 22:34:00 -0700 (PDT) Received: from hiroh.tok.corp.google.com ([100.103.2.121]) by smtp.gmail.com with ESMTPSA id q19sm54259986pfd.24.2017.07.04.22.33.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Jul 2017 22:33:59 -0700 (PDT) From: Hirokazu Honda To: Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Matthias Brugger Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Hirokazu Honda Subject: [PATCH v3] [media] mtk-vcodec: Show mtk driver error without DEBUG definition Date: Wed, 5 Jul 2017 14:33:48 +0900 Message-Id: <20170705053348.2865-1-hiroh@chromium.org> X-Mailer: git-send-email 2.13.2.725.g09c95d1e9-goog Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A driver error message is shown without DEBUG definition to find an error and debug easily. Signed-off-by: Hirokazu Honda --- drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h index 237e144c194f..c1378c1b402c 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h @@ -32,6 +32,15 @@ extern int mtk_v4l2_dbg_level; extern bool mtk_vcodec_dbg; +#define mtk_v4l2_err(fmt, args...) \ + pr_err("[MTK_V4L2][ERROR] %s:%d: " fmt "\n", __func__, __LINE__, \ + ##args) + +#define mtk_vcodec_err(h, fmt, args...) \ + pr_err("[MTK_VCODEC][ERROR][%d]: %s() " fmt "\n", \ + ((struct mtk_vcodec_ctx *)h->ctx)->id, __func__, ##args) + + #if defined(DEBUG) #define mtk_v4l2_debug(level, fmt, args...) \ @@ -41,11 +50,6 @@ extern bool mtk_vcodec_dbg; level, __func__, __LINE__, ##args); \ } while (0) -#define mtk_v4l2_err(fmt, args...) \ - pr_err("[MTK_V4L2][ERROR] %s:%d: " fmt "\n", __func__, __LINE__, \ - ##args) - - #define mtk_v4l2_debug_enter() mtk_v4l2_debug(3, "+") #define mtk_v4l2_debug_leave() mtk_v4l2_debug(3, "-") @@ -57,22 +61,16 @@ extern bool mtk_vcodec_dbg; __func__, ##args); \ } while (0) -#define mtk_vcodec_err(h, fmt, args...) \ - pr_err("[MTK_VCODEC][ERROR][%d]: %s() " fmt "\n", \ - ((struct mtk_vcodec_ctx *)h->ctx)->id, __func__, ##args) - #define mtk_vcodec_debug_enter(h) mtk_vcodec_debug(h, "+") #define mtk_vcodec_debug_leave(h) mtk_vcodec_debug(h, "-") #else #define mtk_v4l2_debug(level, fmt, args...) {} -#define mtk_v4l2_err(fmt, args...) {} #define mtk_v4l2_debug_enter() {} #define mtk_v4l2_debug_leave() {} #define mtk_vcodec_debug(h, fmt, args...) {} -#define mtk_vcodec_err(h, fmt, args...) {} #define mtk_vcodec_debug_enter(h) {} #define mtk_vcodec_debug_leave(h) {}