From patchwork Sat Jul 8 00:41:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amitoj Kaur Chawla X-Patchwork-Id: 9831277 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 961D560361 for ; Sat, 8 Jul 2017 00:41:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 885B523794 for ; Sat, 8 Jul 2017 00:41:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 78F7D2838B; Sat, 8 Jul 2017 00:41:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 370582838B for ; Sat, 8 Jul 2017 00:41:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbdGHAlC (ORCPT ); Fri, 7 Jul 2017 20:41:02 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:34078 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbdGHAlB (ORCPT ); Fri, 7 Jul 2017 20:41:01 -0400 Received: by mail-qt0-f195.google.com with SMTP id m54so6235448qtb.1; Fri, 07 Jul 2017 17:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=7+em1VDmclYxFBdol5SQERIH8ggzKedxR8KaGywzi3w=; b=pj79slmC6X57s0MDwhwh2EGH/n17m/F88HAL3qkXCv6bajIyZpRhynkiDnbOQvoPqZ 9GG6Q6CUuc5xyNqanIcvn8XtgYN0QBABxDlAI4yE2ZTAzl6PSUHBwYi1nHuUkpoXW7VK +l8VKFsWh/VmoKzOIflJ2ppygKY70bUln9LhKbgVHPa0GBDKMMTVkCmkQmHpOuQ9ZTaf Z2LudDrkaB4PnlD7xD1xbiOeDa1abX5QG35rZsTgJz4YUpjbgn1baTUu1t6jJfda4Vll tU/9ZcMuJMK1LG3XWs+7tgqlFqbMJv2P9XrDJ40HCq2gFQjZbQCX+Jy2BxVUkhDlA9xt JcZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=7+em1VDmclYxFBdol5SQERIH8ggzKedxR8KaGywzi3w=; b=b1ixLdd2XWsTzl/ZrTJ0OQ9yJmb8C2J89JEd5O9Pofn576VSRQ9T5gblemX6gm1hAm m7twGpSiX6qqiF5c4Q7QPxkIeAcc3c2T35ATXpbTi4eiI4SagcwlXuRPjYdPI/skgNTq P1VTcYi02LfWwe1TPe8RFRDVkgzMWS+KOms6Nt0KKQUVgXyroyFigKni1kVH5mJKLKrB t1a1mwsJYvRmSYxC35H9fhqukbcG6MkkoYO+JTXVusHliW3TDcPqhO4kz/TH0RlqoIt9 pODNxY3jypEHqXEqefXH4J79HLfvys/3r/7zD3aeUqBHO+q6+OjxnPb0VABNrtti8XG3 Kdow== X-Gm-Message-State: AKS2vOxfkvadgMCu5hsLfd1/WKuswtAj329LnBHpQKf3NpGJjBTi1ICw 6Srs/6sNHuXQhVk/ X-Received: by 10.200.40.207 with SMTP id j15mr75748549qtj.186.1499474449841; Fri, 07 Jul 2017 17:40:49 -0700 (PDT) Received: from amitoj-Inspiron-3542 (addr16212925186.ippl.jhmi.edu. [162.129.251.86]) by smtp.gmail.com with ESMTPSA id s5sm3731203qkl.9.2017.07.07.17.40.49 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 07 Jul 2017 17:40:49 -0700 (PDT) Date: Fri, 7 Jul 2017 20:41:02 -0400 From: Amitoj Kaur Chawla To: mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree() Message-ID: <20170708004102.GA27161@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Conditionally calling kfree()/vfree() can be replaced by a call to kvfree() which handles both kmalloced memory and vmalloced memory. Consequently removed an unnecessary comment. The Coccinelle semantic patch used to make the change is as follows: // @@ expression a; @@ - if(...) { vfree(a); } - else { kfree(a); } + kvfree(a); @@ expression a; @@ - if(...) { kfree(a); } - else { vfree(a); } + kvfree(a); // Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c index 97093ba..a156dd424 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c @@ -117,11 +117,7 @@ void *atomisp_kernel_zalloc(size_t bytes, bool zero_mem) */ void atomisp_kernel_free(void *ptr) { - /* Verify if buffer was allocated by vmalloc() or kmalloc() */ - if (is_vmalloc_addr(ptr)) - vfree(ptr); - else - kfree(ptr); + kvfree(ptr); } /*